htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always use last LtiParamters if multiple are stored.

Browse Source 
Still unsure, how that could happen. We want to prevent that
This commit is contained in:
Sebastian Serth
2020-03-19 21:43:11 +01:00
parent 615dd2eb61
commit ff0b72ead4
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/concerns/lti.rb
View File

@ -145,7 +145,7 @@ module Lti
if session[:consumer_id] if session[:consumer_id]
lti_parameter = LtiParameter.where(consumers_id: session[:consumer_id], lti_parameter = LtiParameter.where(consumers_id: session[:consumer_id],
external_users_id: user_id, external_users_id: user_id,
exercises_id: exercise_id).first exercises_id: exercise_id).last
consumer = Consumer.find_by(id: session[:consumer_id]) consumer = Consumer.find_by(id: session[:consumer_id])
provider = build_tool_provider(consumer: consumer, parameters: lti_parameter.lti_parameters) provider = build_tool_provider(consumer: consumer, parameters: lti_parameter.lti_parameters)

6
app/controllers/exercises_controller.rb
View File

@ -264,8 +264,8 @@ class ExercisesController < ApplicationController
end end
def set_course_token def set_course_token
lti_parameters = LtiParameter.find_by(external_users_id: current_user.id, lti_parameters = LtiParameter.where(external_users_id: current_user.id,
exercises_id: @exercise.id) exercises_id: @exercise.id).last
if lti_parameters if lti_parameters
lti_json = lti_parameters.lti_parameters["launch_presentation_return_url"] lti_json = lti_parameters.lti_parameters["launch_presentation_return_url"]
@ -337,7 +337,7 @@ class ExercisesController < ApplicationController
lti_parameter = LtiParameter.where(consumers_id: session[:consumer_id], lti_parameter = LtiParameter.where(consumers_id: session[:consumer_id],
external_users_id: @submission.user_id, external_users_id: @submission.user_id,
exercises_id: @submission.exercise_id).first exercises_id: @submission.exercise_id).last
path = lti_return_path(consumer_id: session[:consumer_id], path = lti_return_path(consumer_id: session[:consumer_id],
submission_id: @submission.id, submission_id: @submission.id,

2
app/helpers/lti_helper.rb
View File

@ -6,7 +6,7 @@ module LtiHelper
lti_parameters = LtiParameter.where(consumers_id: consumer_id, lti_parameters = LtiParameter.where(consumers_id: consumer_id,
external_users_id: external_user_id, external_users_id: external_user_id,
exercises_id: exercise_id).lis_outcome_service_url? exercises_id: exercise_id).lis_outcome_service_url?.last
!lti_parameters.nil? && lti_parameters.present? !lti_parameters.nil? && lti_parameters.present?
end end
end end