20 Commits

Author SHA1 Message Date
01accdae58 Use author_in_programming_group? policy for files & RfCs
* Allow all members of a programming group to list and solve RfCs
* Also adjust policy specs to respect programming groups
2023-08-24 19:32:06 +02:00
e097036296 Fix RfC Visibility to work as intended
The RfC Visibility of a consumer is intended to restrict who can access which RfCs. So far, those restrictions were only applied one way, for learners of a restricted consumer to view other (external) RfCs. However, the other way around should also work: If a RfC was created as part of a restricted consumer, no other external user should be able to interfere with this RfC. This commit, therefore, adds this direction as well and covers both directions with tests.
2023-07-13 11:02:10 +02:00
d0b713ddcd Dramatically improve RfC query
While the code gets more complex, the new query will first filter all relevant RfCs and only use the `with_last_activity` scope for the current page.

Using `distinct` in the policy is not required (no duplicated RfCs), but causes issues for the ordering otherwise. Therefore, it is removed.

Fixes CODEOCEAN-J2
2023-02-21 01:27:32 +01:00
34c387c6a1 Remove outdated methods from RequestForCommentPolicy 2023-02-20 23:47:06 +01:00
76f592c88d Consider RfC visibility to view / change RfCs 2023-02-20 23:47:06 +01:00
9c3392b324 Add consumer-based RfC Visibility settings
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
9a0f26a84f Allow admins and teachers to remove explicit RfC text 2022-04-28 15:31:58 +02:00
da0a682ffb Apply manual rubocop fixes 2021-05-14 22:03:06 +02:00
40d83dbb1d Fix access to exercise-specific RfC listing 2021-04-07 14:06:32 +02:00
8ebe59b692 Revert changes for Python20 fishbowl experiment
* Show all RfCs again, even those with #loesung
2021-03-08 23:15:58 +01:00
fee929fe41 Check for null in RfC question 2020-11-17 21:54:01 +01:00
6f3300c66a Hide RfCs with keyword #loesung 2020-11-17 00:46:57 +01:00
20a9350b35 Add missing policies 2020-10-28 21:48:48 +01:00
3665058435 Fix tests and slightly refactor some policies 2018-12-12 14:09:20 +01:00
d3f67ab4c7 Rethink permissions in CodeOcean for usage in schools and adopt views 2018-12-12 14:09:19 +01:00
f0fb52d92a Add thank you note to rfc 2017-06-08 16:46:15 +02:00
58f76f53e6 added a search for request_for_comments.
fixed translation of model for request_for_comments
2017-04-03 19:49:03 +02:00
3f398c6047 add feedback for exercises 2017-03-30 22:06:17 +02:00
2a52b66daa rfc can now be solved.
show.html still needs to be finished
2016-06-24 16:44:34 +02:00
172ca91329 bugfixes, policies, errors now have a link to the submissions 2015-04-10 20:23:38 +02:00