149 Commits

Author SHA1 Message Date
f8330b39fb Replace manual activerecord translations with helpers 2024-05-21 19:42:26 +02:00
dd7b09e1e3 Improve visual difference for solved and soft-solved RfCs 2024-04-24 12:18:47 +02:00
7cc4fb00c6 RfCs: Allow filtering for any states
We want to differentiate between those RfCs explicitly marked as solved, those potentially solved since the author reached the maximum score, and those being unsolved where the author has not yet reached the full score yet.
2024-04-24 12:18:47 +02:00
9a9efd5caa Lint Slim files and fix offenses
The fixing was partially done manually and partially automatically.
2024-04-18 08:31:24 +02:00
bbee854002 Allow RfC index action for exercises to be nested 2023-10-23 18:17:42 +02:00
e7e8798f8e Disable sorttable on Ransack-sorted columns 2023-10-03 11:31:31 +02:00
0e387ffda2 Add association for Comments and RequestForComments
For the submission and comments, I mainly decided to use a `has_one` association. Based on the database schema, multiple request for comments could be allowed (i.e., for each file or submission), but this won't happen practically (since we always create new submissions and files). Hence, the `has_one` association is representing our relationship better.
2023-09-25 18:17:52 +02:00
32893bed43 Filter test results on RfC page based on new test attribute 2023-08-01 16:24:13 +02:00
944b455194 Introduce Dark Mode
This commit mainly changes the color definitions. Mostly, those changes are semantically equally, but there are a few changes that occurred to align the color scheme within the app.
2023-07-31 11:48:42 +02:00
a99da79550 Disable sorttable on tables without rows
Otherwise, the first element of the table body is being fetched which might result in an error for empty tables.

Fixes CODEOCEAN-JZ
2023-03-14 18:27:38 +01:00
d0717fb178 Reduce SQL queries for RfC index actions
By using includes and carefully selecting objects through references, all required objects are only queried once.
2023-02-20 23:47:06 +01:00
9c3392b324 Add consumer-based RfC Visibility settings
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
a9c642a116 CSP: Extract RfC JS from view to assets
Relates to CODEOCEAN-CP
2022-11-16 19:47:58 +01:00
4f0b8c3c42 Reduce usage of @current_user (use helper instead) 2022-11-02 12:27:38 +01:00
a2bb2844b4 Add a Content Security Policy 2022-09-06 11:20:57 +02:00
8a055a0d68 Update Bootstrap from v4 to v5 2022-08-12 11:45:32 +02:00
b98c37ae64 Rename v4 FontAwesome icons to match v5/v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4#icons-renamed-since-version-4
2022-08-09 14:17:32 +02:00
4ef7da839d Use TestrunMessages instead of Testrun.output when displaying output 2022-04-29 22:44:35 +02:00
9a0f26a84f Allow admins and teachers to remove explicit RfC text 2022-04-28 15:31:58 +02:00
b8bf43eae8 Fix route path for update and delete of comments 2021-11-25 10:07:24 +01:00
18f05db138 Always show CSRF error message for Ajax 2021-11-23 01:37:50 +01:00
eb69697b9a Fix missing routes incompatible with a subpath 2021-11-03 16:02:21 +01:00
237c225732 Add support for running CodeOcean under a subpath
* Also refactor (JavaScript) routes
2021-07-06 19:33:55 +02:00
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
1d5ceebd7b Fix RfC filter for unnamed study groups 2021-04-09 10:25:41 +02:00
b10e23dd16 Upgrade to newest Sentry 2021-03-04 14:02:16 +01:00
028fc2989a #18 Add sql index for unpublished exercises
And remove spec for remove feature
2020-12-15 12:17:11 +01:00
3d7bddcad1 Adjust RegEx for RfC show 2020-11-21 00:50:59 +01:00
9fcb178839 Check for null in RfC RegEx 2020-11-17 21:46:42 +01:00
ce3d9b488d Hotfix: Hide linter run for RfCs 2020-11-01 22:39:29 +01:00
75a2929b39 Hotfix: Hide linter run for RfCs 2020-11-01 22:35:10 +01:00
87308f72a4 Allow access to RfCs based on migrated exercises 2020-10-28 13:57:47 +01:00
5d7d8a7f68 Replace window.location with the full URL to prevent passing query parameters
* Example before:
location + '/mark_as_solved'
/request_for_comments/30885?locale=de/mark_as_solved

Now: //localhost:3333/request_for_comments/30885/mark_as_solved

Note: https or http will be added automatically by browsers
2020-10-28 13:41:41 +01:00
4cb34a611d Allow empty string values to be matched 2020-10-28 01:15:33 +01:00
a47ce7d069 Add Raven context to RfC show 2020-10-27 23:47:13 +01:00
9ddeb91c41 Remove leftovers from PR #117; exercise feedback on RfC show 2020-10-20 12:15:45 +02:00
59e13d432d Hide linter runs from RfCs 2020-10-15 18:23:14 +02:00
854d1dd032 Improve form filter style 2020-05-05 16:52:29 +02:00
2de33c2531 Preserve webserver from wasting time in re-constructing output message for RfCs 2020-03-26 16:28:56 +01:00
1ed5746746 Revert unintended changes 2020-03-14 22:55:48 +02:00
fc5b02f2d9 Fix newline bug when editing comments 2020-03-14 21:42:47 +02:00
42d66b6a39 Fix parsing of " in RfC output 2020-01-27 15:44:27 +01:00
951171743d Merge pull request #261 from openHPI/feature/la-dashboard
Add LA dashboard architecture
2019-03-12 14:30:25 +01:00
d63700c7db Add live dashboard for teachers in the context of an exercise
This commit also adds the fundamentals for ActionCable
2019-03-06 14:00:59 +01:00
6e03939c10 Add StudyGroup to submissions and show it for submissions and RfCs
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
d4f1c5aee1 Use correct policy to check if RfC could be accessed 2019-02-07 21:13:21 +01:00
2125fb1c1d Ensure views only link to those actions allowed for current user 2018-12-12 14:09:19 +01:00
d7dcbdc799 Merge pull request #200 from openHPI/remove-ab-tests
Remove ab tests
2018-11-15 18:02:34 +01:00
41bd5bac10 Convert .html.erb templates to .html.slim 2018-11-06 16:49:42 +01:00
7bdb962616 Update Bootstrap to v4.1, fix chosen.js and pagedown on multiple sites 2018-11-06 16:49:41 +01:00