Sebastian Serth
bcdc71021e
Fix Rubocop offenses
2023-06-11 20:46:45 +02:00
Sebastian Serth
76f592c88d
Consider RfC visibility to view / change RfCs
2023-02-20 23:47:06 +01:00
Sebastian Serth
574e99eddd
Fix rubocop offenses - Requires Ruby 3.1+
2022-11-25 11:10:06 +01:00
Sebastian Serth
5881795d5f
Memorize config options instead of reading them from file over and over again
2022-09-23 21:35:22 +02:00
Sebastian Serth
0e7c38657f
Allow teachers to access internal users and manage them in their study groups
2022-09-22 19:24:26 +02:00
Sebastian Serth
964048927a
Updated teacher_in_study_group? method to check for common teacher role
2022-09-22 19:24:26 +02:00
Sebastian Serth
521626275f
Use create for all users in specs where necessary
2022-09-22 19:24:26 +02:00
Sebastian Serth
9c9f45ff77
Redefine user roles with their role in a study group
2022-09-22 19:24:26 +02:00
Sebastian Serth
49f4f0e6c5
Refactor exercise_controller and move more checks to policy
...
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
Sebastian Serth
e5879eb606
Simplify permission specs
...
* Remove iteration if not required
* Unify usage of parentheses for `permissions` call
2022-08-22 17:51:57 +02:00
Janis4411
e0c2c7b806
Hide score button if exercise has no tests
...
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
Sebastian Serth
ea85519163
Update bundle (with newest rubocop version) and fix offenses
2022-01-04 09:42:37 +01:00
Sebastian Serth
30603cb7ab
Generalize method and constant names for runner management
2021-11-01 17:12:53 +01:00
Konrad Hanff
0280c0282e
Add tests for synchronizing all execution environments
...
This adds policy tests to ensure only an admin can synchronize all
execution environments. It also adds controller tests that check that
all execution environments get synchronized.
2021-11-01 17:12:49 +01:00
Sebastian Serth
da0a682ffb
Apply manual rubocop fixes
2021-05-14 22:03:06 +02:00
Sebastian Serth
6cbecb5b39
Apply automatic rubocop fixes
2021-05-14 22:03:06 +02:00
Tobias Kantusch
40d83dbb1d
Fix access to exercise-specific RfC listing
2021-04-07 14:06:32 +02:00
Sebastian Serth
293bcccc80
Introduce new enabled option for CodeHarbor
...
* Fix tests to ensure they work independent of config option
2021-02-16 14:29:54 +01:00
Sebastian Serth
f5492ca35d
Improve CodeOcean::FilePolicy with specs
2020-12-07 14:41:30 +01:00
Karol
835b70b000
fix typo
2020-10-29 18:22:33 +01:00
Karol
517886ea0b
fix codeharbor_export policies, add specs
2020-10-29 18:06:14 +01:00
Sebastian Serth
afafe0c218
Adjust teacher permissions:
...
* Hide non-public exercises and proxy exercises
* Hide average working time value on statistic page
* Add hint about filter to submission page for teachers
* Hide display name from feedback page
2020-09-07 19:04:34 +02:00
Sebastian Serth
914eeb6035
Add submission deadline to exercises and allow teachers to view their submissions
2020-05-07 21:23:27 +02:00
Karol
da8d31279c
review points
2019-12-16 17:38:32 +01:00
Karol
c89ee6c102
model and policy specs
2019-12-07 13:11:48 +01:00
Sebastian Serth
924f94f254
Fix failing tests for new permissions
2019-11-29 15:50:50 +01:00
Sebastian Serth
3665058435
Fix tests and slightly refactor some policies
2018-12-12 14:09:20 +01:00
Sebastian Serth
56c59a616e
Completely remove old non-structured errors and migrate existing ones.
2018-11-30 11:27:25 +01:00
Sebastian Serth
efacb5a6a9
Completely remove old hints connected to the execution environment
2018-11-28 01:21:13 +01:00
Sebastian Serth
90defa8f89
Fix tests and rename request variable in specs to perform_request
...
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
2018-11-06 16:49:42 +01:00
Sebastian Serth
de52db89f0
Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
...
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de >
2018-11-06 16:46:00 +01:00
Ralf Teusner
fc873cb053
second run of replacement regex from https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md ...
...
Nested calls seem to be fun..
2017-11-15 15:37:42 +01:00
Ralf Teusner
0e26ab98c8
rename factory_girl_(rails) to factory_bot_(rails)
2017-11-15 15:18:07 +01:00
yqbk
c937a1a9ef
clean pull request
2016-10-24 23:02:44 +02:00
yqbk
7a76c4c6f1
try out new code
2016-10-11 13:12:00 +02:00
yqbk
1945a47109
apply changes after review
2016-10-11 12:44:16 +02:00
yqbk
032c201b94
repair database query
2016-08-03 14:08:01 +02:00
yqbk
4183a16178
merge with master
2016-08-03 12:09:58 +02:00
yqbk
16206cf58f
restore one line
2016-07-04 17:56:57 +02:00
yqbk
2bb1362520
further delete (spec files)
2016-07-04 16:59:30 +02:00
yqbk
4c16661bc3
change error policies
2016-06-07 18:22:45 +02:00
yqbk
d980ffb4c0
add role author to execution_environment_policy
2016-05-31 18:39:03 +02:00
yqbk
9b07a68e3a
repair :show issue for external users
2016-05-31 17:33:38 +02:00
Hauke Klement
6ee0b6bf81
implemented partial batch update for exercises
2015-03-12 11:05:11 +01:00
Hauke Klement
d222d94bbe
changed database cleaning strategy
2015-02-18 11:03:56 +01:00
Hauke Klement
8e374c6914
use #described_class, as suggested by RuboCop
2015-02-16 17:04:28 +01:00
Hauke Klement
59ca0a57c3
administrator dashboard for observing the Docker container pool
2015-02-10 12:23:26 +01:00
Hauke Klement
b08bc8aef2
sped up some tests
2015-01-30 10:50:44 +01:00
Hauke Klement
db2a9a4261
sped up some tests
2015-01-29 18:19:45 +01:00
Hauke Klement
cbde9529aa
implemented team-dependent exercise policy
2015-01-29 17:13:22 +01:00
