Commit Graph

56 Commits

Author SHA1 Message Date
0f55c64ddd Refactor LTI study group assignment 2021-02-16 22:01:11 +01:00
a5da0eb91e Delete study_group_id for LTI users on sign out 2021-02-01 15:56:23 +01:00
6900d4ef2c Add collapse_exercise_description LTI parameter 2021-01-29 13:54:47 +01:00
423a5b08f9 Allow internal user to be part of an study group 2021-01-11 14:22:50 +01:00
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
993fb88f03 Enable submit via API client 2020-11-25 20:47:28 +01:00
1b5d1d3dca Reduce score sent via LTI if too late 2020-10-28 11:58:40 +01:00
4ee1f3aada Remove teacher access for informatiktag2020 2020-09-09 10:17:46 +02:00
6cae31ae8d Allow teacher access for informatiktag2020 2020-09-09 10:17:17 +02:00
5547ff5ac5 Fix comment 2020-05-12 17:54:37 +02:00
564b249e50 Refactor send_score to have access to the submission 2020-05-12 17:51:07 +02:00
ff0b72ead4 Always use last LtiParamters if multiple are stored.
Still unsure, how that could happen. We want to prevent that
2020-03-19 22:19:05 +01:00
42d5480167 Ensure to clear LTI session once the score is submitted 2020-03-06 16:32:31 +01:00
b63280ff97 Increase performace for studyGroup membership 2020-03-05 11:59:25 +01:00
ca1dd0e7dd Add more info for ReadTimeout issues 2020-03-05 10:38:00 +01:00
f2c45b2488 Add more LTI debug messages 2020-03-04 19:37:05 +01:00
58031587de Check @exercise prior usage 2020-03-04 17:57:45 +01:00
dbfc1b2e11 Add additional logging for Sentry 2020-03-04 17:42:07 +01:00
7b00bb483e Allow different StudyGroup names in CodeOcean than on MOOC platforms 2020-03-04 10:57:01 +01:00
67af04f82d Revert "Prevent updating the user role for LTI launches"
This reverts commit d9770396
2020-02-03 11:37:38 +01:00
d977039699 Prevent updating the user role for LTI launches 2020-02-02 12:35:24 +01:00
6d16dfe14d Add embed options to disable redirect to either rfcs or feedback 2020-01-15 14:39:36 +01:00
baa0784ede Add custom_embed_option to disallow downloading submissions 2019-03-29 14:56:14 +01:00
6e03939c10 Add StudyGroup to submissions and show it for submissions and RfCs
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
9087d42088 Fix usage of incorrect downcase method 2018-12-19 19:47:16 +01:00
ac7e41d8b3 Merge pull request #248 from openHPI/improve_groups
Improve groups with a view and always create a group
2018-12-19 13:57:41 +01:00
d95cf1cffb Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/controllers/concerns/lti.rb
2018-12-19 01:44:34 +01:00
c0608b6f50 Don't set admin privileges through LTI 2018-12-19 01:43:37 +01:00
7dc83065eb Create study groups for every LTI launch 2018-12-14 15:11:50 +01:00
2c29bf4e2b Merge branch 'master' into add_groups 2018-12-14 00:57:26 +01:00
1a26d67c82 Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/views/application/_breadcrumbs.html.slim
#	app/views/application/welcome.html.slim
#	app/views/exercise_collections/show.html.slim
#	app/views/external_users/index.html.slim
#	app/views/layouts/application.html.slim
#	app/views/proxy_exercises/index.html.slim
#	app/views/user_exercise_feedbacks/index.html.slim
#	app/views/user_mailer/send_thank_you_note.slim
2018-12-14 00:53:06 +01:00
3665058435 Fix tests and slightly refactor some policies 2018-12-12 14:09:20 +01:00
71fd3b9b07 Add role to ExternalUser and update it via LTI 2018-12-12 14:09:19 +01:00
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
8d1c846fae changes to newrelic 2017-09-20 13:29:26 +02:00
ce2823e871 restrict name to be set to lis_person_name_full (should be display name) or to lis_person_name_given (should be first name).
don't use xikolo api any longer for consumer openHPI, use the values in CodeOcean.
2017-04-03 15:26:02 +02:00
12adfde6c2 search bar now searches in forum of the course from where the LTI request came from. alternatively searches in the java 2017 course.
show interventions only in the current java course
2017-03-21 10:31:45 +01:00
1eea3fab4c lots of renaming to _ names instead of camelCase 2017-03-21 10:31:32 +01:00
d5b2ea4269 added proxy exercise dispatching to LTI module. Submissions now set user before the exercise token gets validated. this we need to set the exercise behind the proxy exercise 2017-03-21 10:31:32 +01:00
4af24d4317 fixing tests p2 lti_spec tests all passed 2017-01-13 00:37:07 +01:00
5fe12bfa78 fixing tests p1 2017-01-12 18:12:36 +01:00
e4daa7ece3 only destroy LTI_parameter when exercise is submitted 2017-01-12 16:03:30 +01:00
dd4c789fed replaced session_paramerters with server params for security reasons
cleaned up comments
2017-01-12 15:10:34 +01:00
41a61a8507 Fixed the destroy session logic.
1. an exercise_id is provided ==> only the LtiParameter object for the current user, consumer, and exercise is deleted.
2. no exercise_id is provided ==> external user and consumer are removed from the session, all LtiParameter objects for this user and consumer are deleted.

This enables users to have several tabs with exercises open and submitting the results to the tool consumer.
When an exercise has been submitted, the user cannot use the back button to get back to CodeOcean and work on the submitted or any other exercise.
For now a warning has been added to the info text to tell users not to do this. (As the LtiParameters have been deleted, the points can no more be submitted to the consumer.)
@TODO disable/redirect back button?
2016-12-31 17:21:46 +01:00
edb813ab14 added separate value for the actual external_id of the external user. 2016-12-31 00:58:36 +01:00
f318c62818 session[:external_user_id] has a somewhat misleading name.
As the tests fail however, when the value that  fits the name is entered, I switched it back to the old version.
2016-12-31 00:51:07 +01:00
ca28e0aa87 updated rails from 4.1.13 to 4.2.5. This is required for rails to make use of new features in postgres 9.5
@Ralf
TODO: migration /Users/groucho/Documents/HPI/workspace/Xikolo-CodeOcean/codeocean/db/migrate/20160204111716_add_user_to_code_harbor_link.rb
is broken. A reference is made to table users which does not exist.
Workaround: run rake db:schema:load before running db:migrate. Still this should be fixed.
2016-12-31 00:05:23 +01:00
325ea25849 Replaced session[:lti_parameters] with proper LtiParameter object.
Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
2016-12-30 09:45:39 +01:00