Commit Graph

98 Commits

Author SHA1 Message Date
d08707f62e Fix switch_locale to return the block result 2021-06-28 16:08:24 +02:00
1b71163a77 Refactor locale with around method 2021-06-25 17:36:56 +02:00
e7cf4ef5db Apply automatic rubocop fixes 2021-06-25 14:41:49 +02:00
cb9870447f Update Bundle
* Also fix new offenses discovered by the new Rubocop version
2021-06-01 17:41:54 +02:00
da0a682ffb Apply manual rubocop fixes 2021-05-14 22:03:06 +02:00
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
ebdfd4ab63 Re-enable oscillating tests 2021-05-12 16:47:05 +02:00
2b32829e60 Upgrade DatabaseCleaner strategy 2021-05-12 16:47:05 +02:00
8378070bc2 Upgrade to Rails 6.0 and apply new framework defaults 2021-05-12 16:47:05 +02:00
1e5a9b0825 Remove unused SubmissionsController#stop action 2021-04-07 17:45:38 +02:00
40d83dbb1d Fix access to exercise-specific RfC listing 2021-04-07 14:06:32 +02:00
b10e23dd16 Upgrade to newest Sentry 2021-03-04 14:02:16 +01:00
293bcccc80 Introduce new enabled option for CodeHarbor
* Fix tests to ensure they work independent of config option
2021-02-16 14:29:54 +01:00
bc05a363f2 Fix spec for InternalUser#forgot_password 2021-01-27 18:40:53 +01:00
028fc2989a #18 Add sql index for unpublished exercises
And remove spec for remove feature
2020-12-15 12:17:11 +01:00
f5492ca35d Improve CodeOcean::FilePolicy with specs 2020-12-07 14:41:30 +01:00
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
be3ec82bd4 Add new file role teacher_defined_linter 2020-10-15 00:43:57 +02:00
758f2b3365 Adopt tests to respect Raven context 2020-01-29 09:55:35 +01:00
f49cd0bed4 forbid users to import an exercise they do not have access to (previously a new one was created) 2019-12-18 17:52:34 +01:00
1ddd6e19f5 add transaction spec 2019-12-14 12:34:55 +01:00
f680916385 remove create_new functionality, when exercise exists on CH but is not editable 2019-12-13 16:43:19 +01:00
5625fa63b0 add controller specs 2019-12-06 17:25:00 +01:00
2c29bf4e2b Merge branch 'master' into add_groups 2018-12-14 00:57:26 +01:00
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
56c59a616e Completely remove old non-structured errors and migrate existing ones. 2018-11-30 11:27:25 +01:00
efacb5a6a9 Completely remove old hints connected to the execution environment 2018-11-28 01:21:13 +01:00
90defa8f89 Fix tests and rename request variable in specs to perform_request
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
2018-11-06 16:49:42 +01:00
9106ab182b Include Webpack and use it for jQuery, Bootstrap and chosen.js 2018-11-06 16:49:42 +01:00
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
ff24a0bf0b Move non-empty files from test dir to spec and adopt specs
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:45:59 +01:00
2c9f1a2917 Add tests for events controller 2018-08-15 14:40:59 +02:00
f5337fcb59 Add tests for statistics controller routes 2018-05-07 17:17:56 +02:00
6377c6ca0f Use skip instead of misused pending in oscillating tests 2018-01-31 13:06:18 +01:00
e934a29a45 Set oscillating tests to pending 2017-12-20 10:36:31 +01:00
fc873cb053 second run of replacement regex from https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md ...
Nested calls seem to be fun..
2017-11-15 15:37:42 +01:00
0e26ab98c8 rename factory_girl_(rails) to factory_bot_(rails) 2017-11-15 15:18:07 +01:00
0fd993c1cd Move submission url attributes to controller test 2017-10-26 15:48:21 +02:00
34e96e40be Fix submissions controller test json response 2017-10-26 15:43:14 +02:00
a00adbce25 Move *_url spec to controller, because the subscription model does not handle urls anymore 2017-10-16 14:02:40 +02:00
7a61d5a983 tests 2017-03-21 10:31:32 +01:00
d5b2ea4269 added proxy exercise dispatching to LTI module. Submissions now set user before the exercise token gets validated. this we need to set the exercise behind the proxy exercise 2017-03-21 10:31:32 +01:00
4badd82d58 fixed broken test 2017-01-19 14:34:49 +01:00
6bf73757ae fixing tests p3 2017-01-13 09:56:36 +01:00
325ea25849 Replaced session[:lti_parameters] with proper LtiParameter object.
Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
2016-12-30 09:45:39 +01:00
6f1d8b2d38 Marked more locations that might require to be changed when we switch from session to LtiParameters Object 2016-12-27 07:48:59 +01:00
f4c01879bf preparations to replace session with lti_parameters object 2016-12-27 00:13:41 +01:00
d931d431d5 Update submissions_controller_spec.rb
removed some uncommented lines
2016-11-11 17:29:03 +01:00
c937a1a9ef clean pull request 2016-10-24 23:02:44 +02:00