htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,764 Commits 2 Branches 0 Tags
243985ebaf149ceff81a61081d97263fb0752c27
Commit Graph

2104 Commits

Author SHA1 Message Date
Sebastian Serth
838019343e ProFormA: Hide 'delayed' files by default 2022-12-08 10:57:36 +01:00
Sebastian Serth
bec235c8d6 Fix XML parsing with invalid LTI response 
An invalid XML response may be returned if the LTI provider is unavailable and cannot handle our request. We decided against logging in Sentry as this affects a third party functionality we cannot fix ourselves.
Fixes CODEOCEAN-G2
 2022-12-07 23:00:21 +01:00
Sebastian Serth
bc5baed05e Use exec_query for custom SQL execution 
Also align how we use query Postgres from controllers.

The change is mainly due to regular (but not reproducible) issues with the `intervalstyle` defaulting to `postgres` (instead of `iso8601`) and thereby causing issues. We're just experimenting to see whether this change resolves the issue.
 2022-12-06 22:41:00 +01:00
Sebastian Serth
da9a9b3e76 Ensure all text is visible during page load 
We introduce the font-display property. See
https://developer.chrome.com/docs/lighthouse/performance/font-display/
 2022-12-06 18:36:45 +01:00
Sebastian Serth
75c6dfd20b Rename actioncable integration (deprecation warning) 2022-12-06 15:26:50 +01:00
Sebastian Serth
de0c1d368c Add source map for sprockets 2022-12-06 15:26:50 +01:00
Sebastian Serth
9977e1614b Allow external redirect for render host and LTI 
We only use the `launch_presentation_return_url` provided to the @provider, in order to prevent using an open redirect.
 2022-12-05 22:38:13 +01:00
Sebastian Serth
b7a3fd4586 Refactor exercise statistics to use convert times in Ruby 2022-12-05 21:59:34 +01:00
Sebastian Serth
1cfae6101a Introduce additional time helper for managing intervals and durations 2022-12-05 18:22:18 +01:00
Sebastian Serth
df666b4389 Fix missing whitespace for exercise feedback page 2022-12-05 18:21:44 +01:00
dependabot[bot]
90b30e2bf7 Upgrade to Rails 7.0 and apply new framework defaults 
* Remove `send_stream` method pulled in before upgrading Rails
* Remove spring, it is no longer included by default for new apps
* Remove deprecated options from environments
* Remove old asset paths and workarounds no longer needed
* Remove unnecessary `OAUTH_10_SUPPORT` const, LTI still uses OAuth 1.0
* Dump schema with new defaults (and specify precision for timestamps where needed)
 2022-12-04 15:21:59 +01:00
Sebastian Serth
ffe96d9223 Remove I18n.translation_present? monkey patch 2022-12-04 15:03:28 +01:00
Sebastian Serth
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00
Sebastian Serth
dfbf06274c Specify class for html_escape 2022-11-24 17:16:18 +01:00
Sebastian Serth
ab688e09c0 Execute SQL statement in ping controller 2022-11-21 14:52:11 +01:00
Sebastian Serth
25707478ea Require user for Community Solution 
Fixes CODEOCEAN-F7
 2022-11-21 10:48:08 +01:00
Sebastian Serth
b6cecf53aa Pundit: Skip authorization in case of errors 
Fixes CODEOCEAN-F3
 2022-11-17 21:37:45 +01:00
Sebastian Serth
b2af4e0663 Check submission and exercise files when filtering downloads 2022-11-17 20:47:33 +01:00
Sebastian Serth
9bd900bd86 Raise NotAuthorized Error if ID cannot be found 
Fixes CODEOCEAN-F3
 2022-11-17 20:47:33 +01:00
Sebastian Serth
15878f500c Switch order of unloading the autosave timer 
Hypothesis: When unloadAutoSave was called, we first saved (causing this.autosaveTimer to become null) and then tried to clearTimeout on this variable (= on null). This probably never worked?

Hopefully closes CODEOCEAN-B5
 2022-11-16 23:26:25 +01:00
Sebastian Serth
591f776f69 Close WebSocket connection normally 
With Tubesock, we need to send a close frame ourselves. Otherwise, some browsers might display a warning.
 2022-11-16 23:16:49 +01:00
Sebastian Serth
7aaeac03d6 Remove outdated error for used_defined_tests 
Previously, a user-defined test (those run with "Test" instead of "Run") would cause a flash message and a Sentry error if anything was printed to StdErr. As this might happen during user code execution (and therefore is no error), we remove this warning. All existing errors are already caught (compare with enum status in testrun.rb), so it's fine for now.

Fixes CODEOCEAN-BT
 2022-11-16 22:41:07 +01:00
Sebastian Serth
fb494dabbd Re-init Sorttable on turbolinks page load 2022-11-16 20:13:37 +01:00
Sebastian Serth
0950e626ba Convert message data to string before slicing 
Fixes CODEOCEAN-F1
 2022-11-16 19:53:19 +01:00
Sebastian Serth
f17718f69f CSP: Extract JavaScript from layout to assets 
Fixes CODEOCEAN-CP
 2022-11-16 19:47:58 +01:00
Sebastian Serth
a9c642a116 CSP: Extract RfC JS from view to assets 
Relates to CODEOCEAN-CP
 2022-11-16 19:47:58 +01:00
Sebastian Serth
b9f3126f21 CSP: Remove global this in webpack 
Also refactor how we handle global namespace objects.

Fixes CODEOCEAN-DV
 2022-11-16 19:47:58 +01:00
Sebastian Serth
55d7fb2f9a Download file: Return after rendering NotAuthorized Error 
Fixes CODEOCEAN-ET
 2022-11-14 18:21:35 +01:00
Sebastian Serth
d50e6d30e9 List Files: Catch more Runner::Errors 2022-11-14 13:51:04 +01:00
Sebastian Serth
2753e4ef5b Always catch StandardError in Threads and release connection 2022-11-11 22:50:27 +01:00
Sebastian Serth
60f8d9809b Catch error in LiveStreams Controller to avoid concurrency issue 2022-11-10 12:00:56 +01:00
Sebastian Serth
cf957eb715 Prevent reference_implementation to be copied to Runner 2022-11-04 17:30:30 +01:00
Sebastian Serth
de024d9360 Set Content-Type to fixed value for send_runner_file 2022-11-04 16:52:49 +01:00
Sebastian Serth
26433aa2ff Remove duplicated username (log statement) 2022-11-02 14:09:42 +01:00
Sebastian Serth
4f0b8c3c42 Reduce usage of @current_user (use helper instead) 2022-11-02 12:27:38 +01:00
Sebastian Serth
58548555a5 Shell: Add file system browser to retrieve arbitrary files 2022-10-29 18:49:18 +02:00
Sebastian Serth
60078701f5 Editor: Allow file retrieval after code run 2022-10-29 18:49:18 +02:00
Sebastian Serth
fb9672c7a4 FileTree: Allow output as hash, convert to JSON separately 2022-10-29 18:49:18 +02:00
Sebastian Serth
ad8743a7d0 FileTree: Show more distinct icons where possible 2022-10-29 18:49:18 +02:00
Sebastian Serth
cc3739322f Always show sign-out button profile for internal users 2022-10-27 17:06:19 +02:00
Sebastian Serth
eefe3faa13 Re-apply default group when external user signs out 2022-10-27 17:06:04 +02:00
Sebastian Serth
f45fad71dd Add early return support for authentication 2022-10-27 16:14:18 +02:00
Sebastian Serth
dd1f4b0ac8 Merge pull request #939 from openHPI/refactor_proforma_import_export 
Refactor Proforma Import/Export
 2022-10-26 17:58:48 +02:00
Sebastian Serth
c75f52f2c8 Fix Rubocop offenses 2022-10-24 12:28:50 +02:00
Sebastian Serth
b3284bb7c7 Remove unused score pill from feedback and community solution 2022-10-13 19:56:32 +02:00
Sebastian Serth
14bc0b9741 Always show score pill for exercise implement and adjust styling 2022-10-13 19:56:15 +02:00
Sebastian Serth
ef5dd80ea7 Increase wait timeout for new execution environments to 60 sec 2022-10-11 21:14:07 +02:00
Sebastian Serth
66ab00a6bd Fix association to testrun_execution_environment 2022-10-11 21:08:34 +02:00
Sebastian Serth
e9a00353ab Fix: Allow admins to list internal users 2022-10-11 20:21:38 +02:00
Sebastian Serth
d80a8dd64f Fix Submissions index page 
Closes CODEOCEAN-BJ
 2022-10-11 20:21:13 +02:00