Commit Graph

149 Commits

Author SHA1 Message Date
dd1f4b0ac8 Merge pull request #939 from openHPI/refactor_proforma_import_export
Refactor Proforma Import/Export
2022-10-26 17:58:48 +02:00
c75f52f2c8 Fix Rubocop offenses 2022-10-24 12:28:50 +02:00
f7515362a1 Set Content-Type to fixed value for all download actions 2022-10-05 21:46:17 +02:00
3263d4f838 Respect subpath for (render_)protected_upload_path 2022-09-28 11:06:15 +02:00
b866221353 rename route 2022-09-24 21:08:18 +02:00
16c00ec136 Add support for signed URLs used by the render_file function 2022-09-23 21:35:22 +02:00
5881795d5f Memorize config options instead of reading them from file over and over again 2022-09-23 21:35:22 +02:00
e3018c1847 Refactor consumer factory 2022-09-22 19:24:26 +02:00
ec4c6207f0 Refactor internal_users_controller_spec to prevent invalid objects 2022-09-22 19:24:26 +02:00
7e9967e2bf Fix rubocop offenses 2022-09-16 01:03:55 +02:00
d02a1eae81 Validate password strength for internal users 2022-09-14 12:19:25 +02:00
f1aa004284 Use controller method for 404 responses 2022-09-14 01:01:14 +02:00
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
0a16f589e9 Use X-Sendfile to transmit native files and handle file uploads 2022-09-06 01:21:40 +02:00
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
d762f976a8 Add new CodeOcean::File#read method
* With a new method, we can simplify our code to handle differences between file.content and file.native_file.read
2022-08-19 22:42:55 +02:00
a9aab612b6 Extract updating the user role from params 2022-08-18 21:44:26 +02:00
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
cb0f30768f Change HTTP links to HTTPS 2022-08-17 01:29:27 +02:00
4615a49e62 added strong params to comments_controller to prevent users from editing attributes which are not intended to be edited, also created specs to test this behaviour 2022-08-09 14:45:16 +02:00
fa27e3923d Reimplement pending specs with rough skeleton 2022-08-09 11:41:41 +02:00
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
67dd8566b6 added a test scenario to check if autosave submissions are being toggled right 2022-07-20 17:18:36 +02:00
c792b99523 Fix tests for latest locale change 2022-07-15 14:02:10 +02:00
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
d9f40531fb Fix Rubocop offenses 2022-04-20 18:26:53 +02:00
c5c47715b3 Merge branch 'master' into refactor_proforma_import_export
# Conflicts:
#	spec/controllers/exercises_controller_spec.rb
2022-01-11 22:20:18 +01:00
3260d8f82f tiny refactor from exercise_found to task_found 2022-01-11 22:17:09 +01:00
ea85519163 Update bundle (with newest rubocop version) and fix offenses 2022-01-04 09:42:37 +01:00
fb92d382ac Skip verification of Docker image if pool size is empty 2021-11-09 17:49:51 +01:00
79e8caea45 Remove outdated execution environments after syncing all 2021-11-04 20:09:20 +01:00
c1ac401a49 Add retries to working_docker_image?
* Also synchronize images during save
2021-11-04 20:09:19 +01:00
ecf470bddd Refactor sync_environment methods
* Add delete_environment method
* Change return value to allow raising an exception
2021-11-04 20:06:40 +01:00
7f47af99cb Fix order-dependent specs 2021-11-04 19:15:33 +01:00
01ec9343cf Remove usage of DockerClient 2021-11-01 17:13:10 +01:00
953643f05e [Spec] Use strings for image names 2021-11-01 17:13:08 +01:00
2b98905acb Remove usage of DockerClient from execution_environments_controller.rb 2021-11-01 17:13:07 +01:00
1dfee31079 Fix order-dependent execution_environments_controller_spec.rb 2021-11-01 17:13:05 +01:00
d87e23b9a3 Add execute_command method to runner.rb
* This is now used by the score and test runs
* This also re-enables the interactive shell for execution environments
2021-11-01 17:13:05 +01:00
601e1fab5c Remove all occurrences of server-sent events 2021-11-01 17:12:57 +01:00
5037a73f36 Mock runner management settings for spec 2021-11-01 17:12:54 +01:00
30603cb7ab Generalize method and constant names for runner management 2021-11-01 17:12:53 +01:00
b6bc578aea Move submission scoring from controller concern to submission model
Localization and markdown formatting is now done in a controller
spec in order to bring this logic away from the data and towards
the view.
2021-11-01 17:12:50 +01:00
cf58be97ee Fix 17 previously failing specs 2021-11-01 17:12:49 +01:00
0280c0282e Add tests for synchronizing all execution environments
This adds policy tests to ensure only an admin can synchronize all
execution environments. It also adds controller tests that check that
all execution environments get synchronized.
2021-11-01 17:12:49 +01:00
5e913c8a1a Skip failing tests
17 tests are always failing, due to changes introduced when adding the
Runner abstraction. To know only these fail, they now get skipped in
order to make it apparent if tests that should not fail do fail in the
pipeline.
2021-11-01 17:12:48 +01:00
d22d24df4d Add tests for execution environment copy to Poseidon 2021-11-01 17:12:48 +01:00