Commit Graph

41 Commits

Author SHA1 Message Date
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
40d83dbb1d Fix access to exercise-specific RfC listing 2021-04-07 14:06:32 +02:00
8ebe59b692 Revert changes for Python20 fishbowl experiment
* Show all RfCs again, even those with #loesung
2021-03-08 23:15:58 +01:00
78f71fc3bf RfC require user before accessing anything else 2020-12-16 19:24:29 +01:00
028fc2989a #18 Add sql index for unpublished exercises
And remove spec for remove feature
2020-12-15 12:17:11 +01:00
fac29f73d4 Respect user_type for RfC index routes 2020-12-04 16:58:11 +01:00
16093fd94d Mark RfCs with keyword #loesung as solved 2020-11-17 00:55:00 +01:00
6f3300c66a Hide RfCs with keyword #loesung 2020-11-17 00:46:57 +01:00
4d5e00fde5 Require authorization for RfCs and remove obsolete routes 2020-10-28 13:24:44 +01:00
9ddeb91c41 Remove leftovers from PR #117; exercise feedback on RfC show 2020-10-20 12:15:45 +02:00
06b3059655 Ensure to close DB connections within threads 2020-03-04 12:25:09 +01:00
a0b544fb26 Upgrade Ransack #search to #ransack to prevent deprecation warning 2019-03-11 09:59:38 +01:00
d63700c7db Add live dashboard for teachers in the context of an exercise
This commit also adds the fundamentals for ActionCable
2019-03-06 14:00:59 +01:00
6e03939c10 Add StudyGroup to submissions and show it for submissions and RfCs
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
dbb201ccad Clean up controller 2018-02-28 13:58:55 +01:00
6e022528a0 Move methods to model 2018-02-28 13:41:47 +01:00
efc271c4ed add column full_score_reached, fill it accordingly and show information in the rfc index 2018-01-31 11:23:30 +01:00
194984a620 add cause to testruns
trigger run and assess on request_for_comment
2017-09-21 17:21:10 +02:00
28741854a6 Merge pull request #125 from openHPI/rework-comment-modal
Rework comment modal
2017-09-20 16:51:47 +02:00
8f372bab04 added total_entries attribute to fix pagination on more complicated query. Don't know why this is necessary. Fix was found by MGrundke 2017-09-15 14:52:35 +02:00
4baab7430c push commenters to RFC model 2017-09-13 07:06:55 +02:00
9e53fb4ea5 Fix query for RFC activity 2017-08-16 16:03:49 +02:00
06f11ae6f5 Fix RFC lists for RFCs without comments 2017-08-13 16:09:44 +02:00
726ef31ee7 Add new route to view all RFCs the user has commented on 2017-08-13 15:01:11 +02:00
eaac43ac63 Send e-Mail to all commenters if thank you note is given 2017-06-09 14:40:44 +02:00
f0fb52d92a Add thank you note to rfc 2017-06-08 16:46:15 +02:00
6eea338f84 supply search object for my_request_for_comments 2017-04-04 11:08:20 +02:00
58f76f53e6 added a search for request_for_comments.
fixed translation of model for request_for_comments
2017-04-03 19:49:03 +02:00
3f398c6047 add feedback for exercises 2017-03-30 22:06:17 +02:00
ff7446fde6 redirect to RFCs on max score: redirect users to their own RFCs if they are open, fixed wrong usage of user_id (external_id is not used in RFCs, normal id has to be used!). 2016-11-09 17:58:10 +01:00
223df2ffa8 some cleanup of request for comments. Work in progress.
Noticed a flaw when fetching the last submission, which is caused by timezone differences. First step to solve this.
Existing Request for Comments still need to be updated with their current submissionId, the SQL to do that is not yet finished.
2016-07-04 17:44:22 +02:00
2a52b66daa rfc can now be solved.
show.html still needs to be finished
2016-06-24 16:44:34 +02:00
c4405e24b9 Show question in overview 2016-04-30 13:57:23 +02:00
948de1ebb9 Order requests for comment 2016-03-02 17:07:16 +01:00
d292fec47c Code Cleanup: Usage of Polymorphic User instead of ExternalUser and InternalUser
Renamed requestor_user_id -> user_id
Index of request_for_comments now returns the n (5?) newest requests per user. Solved via sliding windows in postgres, code added to model.
Added route to /my_request_for_comments/ that shows all requests for the current user.
Changed view from ERB to slim
2015-09-04 14:05:30 +02:00
dc0b3a2294 cleanup of passed parameters, user_id and user_type are extracted from current user and not used from the passed POST values.. 2015-08-19 15:35:25 +02:00
e520914385 Some correction of column names.
Support for internal as well as external users. Added column user_type and used it where necessary
2015-08-18 17:44:31 +02:00
06131e6e63 Remove logic to find newest submission for an exercise and user. This is no longer necessary, since we update the file ids in editor.js 2015-07-09 16:08:26 +02:00
172ca91329 bugfixes, policies, errors now have a link to the submissions 2015-04-10 20:23:38 +02:00
b8ec3edef2 Show requests for comments and begin work on a view for executing them 2015-03-27 18:10:47 +01:00