Commit Graph

45 Commits

Author SHA1 Message Date
Karol
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
Sebastian Serth
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
Karol
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
Janis4411
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
Karol
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
Sebastian Serth
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
Janis4411
67dd8566b6 added a test scenario to check if autosave submissions are being toggled right 2022-07-20 17:18:36 +02:00
Sebastian Serth
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
Karol
c5c47715b3 Merge branch 'master' into refactor_proforma_import_export
# Conflicts:
#	spec/controllers/exercises_controller_spec.rb
2022-01-11 22:20:18 +01:00
Karol
3260d8f82f tiny refactor from exercise_found to task_found 2022-01-11 22:17:09 +01:00
Sebastian Serth
ea85519163 Update bundle (with newest rubocop version) and fix offenses 2022-01-04 09:42:37 +01:00
Felix Auringer
b6bc578aea Move submission scoring from controller concern to submission model
Localization and markdown formatting is now done in a controller
spec in order to bring this logic away from the data and towards
the view.
2021-11-01 17:12:50 +01:00
Felix Auringer
cf58be97ee Fix 17 previously failing specs 2021-11-01 17:12:49 +01:00
Konrad Hanff
5e913c8a1a Skip failing tests
17 tests are always failing, due to changes introduced when adding the
Runner abstraction. To know only these fail, they now get skipped in
order to make it apparent if tests that should not fail do fail in the
pipeline.
2021-11-01 17:12:48 +01:00
Sebastian Serth
da0a682ffb Apply manual rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
2b32829e60 Upgrade DatabaseCleaner strategy 2021-05-12 16:47:05 +02:00
Sebastian Serth
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
Karol
f49cd0bed4 forbid users to import an exercise they do not have access to (previously a new one was created) 2019-12-18 17:52:34 +01:00
Karol
1ddd6e19f5 add transaction spec 2019-12-14 12:34:55 +01:00
Karol
f680916385 remove create_new functionality, when exercise exists on CH but is not editable 2019-12-13 16:43:19 +01:00
Karol
5625fa63b0 add controller specs 2019-12-06 17:25:00 +01:00
Sebastian Serth
90defa8f89 Fix tests and rename request variable in specs to perform_request
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
2018-11-06 16:49:42 +01:00
Sebastian Serth
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
Ralf Teusner
0e26ab98c8 rename factory_girl_(rails) to factory_bot_(rails) 2017-11-15 15:18:07 +01:00
Tom Staubitz
4badd82d58 fixed broken test 2017-01-19 14:34:49 +01:00
Tom Staubitz
6bf73757ae fixing tests p3 2017-01-13 09:56:36 +01:00
Jan Renz
9c8d0b01eb Fix reset of tasks 2015-04-20 22:30:31 +02:00
Jan Renz
5cb8ae68b0 Added tests 2015-04-20 16:51:50 +02:00
Hauke Klement
4eef3d70d5 minor refactoring of flash messages 2015-03-23 16:42:57 +01:00
Hauke Klement
c294e3b499 do not render the development environment for exercises without visible files 2015-03-21 18:46:02 +01:00
Hauke Klement
1f46f7c3af execute test files concurrently 2015-03-16 17:51:46 +01:00
Hauke Klement
6ee0b6bf81 implemented partial batch update for exercises 2015-03-12 11:05:11 +01:00
Hauke Klement
67c7e1427e fixed issue occurring for progress bars without a value 2015-03-11 10:14:39 +01:00
Hauke Klement
42c8b47d40 concretized redirection expectations in controller specs 2015-02-24 18:57:00 +01:00
Hauke Klement
05509c2ceb added tests 2015-02-24 09:58:04 +01:00
Hauke Klement
f337f1c1a3 added tests 2015-02-23 12:44:22 +01:00
Hauke Klement
8b04b47721 added tests 2015-02-21 11:11:04 +01:00
Hauke Klement
9dab833796 fixed test 2015-02-19 11:29:00 +01:00
Hauke Klement
56acd4c3c3 updated to Rails 4.2 2015-02-18 10:41:26 +01:00
Hauke Klement
a13d1738e2 fixed multiple style guide violations 2015-02-17 10:23:01 +01:00
Hauke Klement
b21a7ee8e8 use shorter notation for creating procs, as suggested by RuboCop 2015-02-17 08:21:00 +01:00
Hauke Klement
232c6b398f extracted method 2015-02-09 16:24:33 +01:00
Hauke Klement
b08bc8aef2 sped up some tests 2015-01-30 10:50:44 +01:00
Hauke Klement
4cbf9970b1 transferred Code Ocean from original repository to GitHub 2015-01-22 10:01:32 +01:00