092487344a
Replace obsolete HTTP status code :unprocessable_entity
...
The new naming is :unprocessable_content and required by Rack 3.1+
2024-06-17 15:07:04 +02:00
8fc5123bae
Exclusively lock Runners during code executions
...
Previously, the same runner could be used multiple times with different submissions simultaneously. This, however, yielded errors, for example when one submission time oud (causing the running to be deleted) while another submission was still executed.
Admin actions, such as the shell, can be still executed regardless of any other code execution.
Fixes CODEOCEAN-HG
Fixes openHPI/poseidon#423
2023-10-31 12:35:24 +01:00
e638e32435
Reduce SQL queries in the RfC controller
...
Fixes CODEOCEAN-Y5
2023-09-26 00:09:21 +02:00
235bf771fe
Always use user object instead of ID and Type
2023-08-26 00:39:47 +02:00
01accdae58
Use author_in_programming_group? policy for files & RfCs
...
* Allow all members of a programming group to list and solve RfCs
* Also adjust policy specs to respect programming groups
2023-08-24 19:32:06 +02:00
be4f2b790d
Add user to testrun
...
* We want to identify a user that has triggered a testrun. Previously (in regular operation), only submission author who were regular users were able to start a testrun. Now, we want to prepare a future where submission authors are programming groups. Still, a testrun is triggered by an individual user and not a group.
* Further, this commit fixes some missing foreign key constrains.
2023-08-24 19:32:06 +02:00
d6c95dd383
Default to first page for RfC pages
2023-02-22 00:05:33 +01:00
2e825f2413
Fix pagination for RfCs
2023-02-21 23:44:34 +01:00
d0b713ddcd
Dramatically improve RfC query
...
While the code gets more complex, the new query will first filter all relevant RfCs and only use the `with_last_activity` scope for the current page.
Using `distinct` in the policy is not required (no duplicated RfCs), but causes issues for the ordering otherwise. Therefore, it is removed.
Fixes CODEOCEAN-J2
2023-02-21 01:27:32 +01:00
d0717fb178
Reduce SQL queries for RfC index actions
...
By using includes and carefully selecting objects through references, all required objects are only queried once.
2023-02-20 23:47:06 +01:00
9c3392b324
Add consumer-based RfC Visibility settings
...
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
83feb67dd5
Update find method for study group in RfC index
2022-08-20 00:58:12 +02:00
c228850ae8
Update find method
2022-08-20 00:37:48 +02:00
145c4aa8d5
Refactor various ruby files
...
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
9a0f26a84f
Allow admins and teachers to remove explicit RfC text
2022-04-28 15:31:58 +02:00
0a6ae91db8
Introduce per_page parameter for custom page size
2022-01-12 20:46:54 +01:00
1e7cf1c622
Prevent parallel execution of run and test during RfC creation
...
* Otherwise, the output of both might be mixed and saved incorrectly for the RfC
2021-11-01 17:13:14 +01:00
5cc180d0e9
Fix rubocop, I18n, cleanup rebase
2021-11-01 17:12:52 +01:00
cf58be97ee
Fix 17 previously failing specs
2021-11-01 17:12:49 +01:00
110f1a5750
Fix rubocop offenses after bundle update
2021-06-30 09:13:25 +02:00
5243808d54
Apply automatic rubocop fixes
2021-05-17 19:40:38 +02:00
da0a682ffb
Apply manual rubocop fixes
2021-05-14 22:03:06 +02:00
6cbecb5b39
Apply automatic rubocop fixes
2021-05-14 22:03:06 +02:00
40d83dbb1d
Fix access to exercise-specific RfC listing
2021-04-07 14:06:32 +02:00
8ebe59b692
Revert changes for Python20 fishbowl experiment
...
* Show all RfCs again, even those with #loesung
2021-03-08 23:15:58 +01:00
78f71fc3bf
RfC require user before accessing anything else
2020-12-16 19:24:29 +01:00
028fc2989a
#18 Add sql index for unpublished exercises
...
And remove spec for remove feature
2020-12-15 12:17:11 +01:00
fac29f73d4
Respect user_type for RfC index routes
2020-12-04 16:58:11 +01:00
16093fd94d
Mark RfCs with keyword #loesung as solved
2020-11-17 00:55:00 +01:00
6f3300c66a
Hide RfCs with keyword #loesung
2020-11-17 00:46:57 +01:00
4d5e00fde5
Require authorization for RfCs and remove obsolete routes
2020-10-28 13:24:44 +01:00
9ddeb91c41
Remove leftovers from PR #117 ; exercise feedback on RfC show
2020-10-20 12:15:45 +02:00
06b3059655
Ensure to close DB connections within threads
2020-03-04 12:25:09 +01:00
a0b544fb26
Upgrade Ransack #search to #ransack to prevent deprecation warning
2019-03-11 09:59:38 +01:00
d63700c7db
Add live dashboard for teachers in the context of an exercise
...
This commit also adds the fundamentals for ActionCable
2019-03-06 14:00:59 +01:00
6e03939c10
Add StudyGroup to submissions and show it for submissions and RfCs
...
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
a0d8b30ef2
Implement support for some basic embed options for work sheets via LTI
...
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
dbb201ccad
Clean up controller
2018-02-28 13:58:55 +01:00
6e022528a0
Move methods to model
2018-02-28 13:41:47 +01:00
efc271c4ed
add column full_score_reached, fill it accordingly and show information in the rfc index
2018-01-31 11:23:30 +01:00
194984a620
add cause to testruns
...
trigger run and assess on request_for_comment
2017-09-21 17:21:10 +02:00
28741854a6
Merge pull request #125 from openHPI/rework-comment-modal
...
Rework comment modal
2017-09-20 16:51:47 +02:00
8f372bab04
added total_entries attribute to fix pagination on more complicated query. Don't know why this is necessary. Fix was found by MGrundke
2017-09-15 14:52:35 +02:00
4baab7430c
push commenters to RFC model
2017-09-13 07:06:55 +02:00
9e53fb4ea5
Fix query for RFC activity
2017-08-16 16:03:49 +02:00
06f11ae6f5
Fix RFC lists for RFCs without comments
2017-08-13 16:09:44 +02:00
726ef31ee7
Add new route to view all RFCs the user has commented on
2017-08-13 15:01:11 +02:00
eaac43ac63
Send e-Mail to all commenters if thank you note is given
2017-06-09 14:40:44 +02:00
f0fb52d92a
Add thank you note to rfc
2017-06-08 16:46:15 +02:00
6eea338f84
supply search object for my_request_for_comments
2017-04-04 11:08:20 +02:00
