Commit Graph

2458 Commits

Author SHA1 Message Date
86c67f3c9a Refactor code execution to use async functions
This refactoring is required for Sentry tracing. It ensures that the respective functions only return as soon as a code execution finished. With this approach, we can then instrument the duration of the functions, so that Sentry spans are created as desired.

Co-authored-by: Jan Graichen <jgraichen@altimos.de>
2024-05-24 14:52:14 +02:00
c8609e5392 Remove leftovers from CommunitySubmission code
This code was unintentionally copied over and was never useful (since we won't execute code when submitting a community solution).

Co-authored-by: Jan Graichen <jgraichen@altimos.de>
2024-05-24 14:52:14 +02:00
61513cc5bc Revert "Fix race condition on JavaScript initializer"
This reverts commit 88c6be88, since it is no longer needed after fixing the root cause in a076da41.
2024-05-21 21:56:31 +02:00
619291c647 Specify the order of JavaScript assets loaded.
Previously, we could face (a rare) race condition with the wrong order. This was caused by Turbolinks and our usage of "components" (e.g., the CodeOceanEditor).

It could happen that Turbolinks fired the `turbolinks:load` event, as all XHR requests finished. In the event handler, we sometimes referred to other components. However, those components weren't initialized yet, potentially. This is due to Sprockets concatenating files in alphabetical order, ignoring our component dependencies.

With this commit, we try to specify the required order and thus aim to implement a permanent fix.

Fixes CODEOCEAN-FRONTEND-7W
Fixes CODEOCEAN-FRONTEND-7D
2024-05-21 21:56:31 +02:00
65416934ea Explicitly specify depend_on relationship between assets and config 2024-05-21 21:56:31 +02:00
336519b21d Refactor CodeOcean::Config class
The new architecture memorizes settings (which we mostly did after reading the config so far) and also exposes the resulting file path as well as further settings.

This change is a prerequisite to define a dependency with Sprockets.
2024-05-21 21:56:31 +02:00
dcaedfa9fe Remove url_helpers from editor.js.erb
- Rather than using a Rails helper, we rely on JsRoutes to provide the route.
- There is no need to remove the events_path if sending events is disabled, so we drop that.
2024-05-21 21:56:31 +02:00
8c506cd47c Add AuthenticationToken to UserMailer.exercise_anomaly_detected 2024-05-21 20:10:00 +02:00
ed69da10da Prefer gender-neutral language for German 2024-05-21 19:56:58 +02:00
f8330b39fb Replace manual activerecord translations with helpers 2024-05-21 19:42:26 +02:00
e551c8a699 Reorder translations and add missing prefixes
- files should be prefixed with code_ocean/
- the markdown editor is part of the application (helper)
2024-05-21 19:42:26 +02:00
1589c9472b Fix missing and unused i18n translations 2024-05-21 19:42:26 +02:00
c6d077ecfe Add missing parentheses to external user statistics slider
Previously, no space was present for the `- 1`, changing the semantics. After linting with 9a9efd5c, a space was added, which requires parentheses.
2024-05-21 11:56:54 +02:00
189f9e28d7 Fix margin for "Administration" menu on small screens 2024-05-21 11:52:58 +02:00
7b769a7673 Enable strict CSP support for ACE
With these changes, ACE no longer requires custom inline styles, removing one further dependency from our CSP style list.
2024-04-26 13:37:25 +02:00
3bfce7f1cb Fix ACE import for Webpack, allowing Web Workers
The previous method worked correctly most of the time, but failed to resolve nested files correctly. This prevented Web Workers from functioning as expected.
2024-04-26 13:37:25 +02:00
f42c56042c Enable Web Worker for ACE editor 2024-04-26 13:37:25 +02:00
4ba5f0d7d8 Enable Web Worker for JStree 2024-04-26 13:37:25 +02:00
da9add4a10 Fix ToastUI editor bug preventing manual codeblock insertion
Manually inserting a codeblock adding three backticks and hitting enter
is not functioning in the ToastUI editor due to an existing bug in the library.
This commit implements a workaround to address the issue.
2024-04-26 13:31:49 +02:00
749074fec0 Add functionality to expand the markdown editor
The editor will now have a default height of 300px but a button will let
the user expand the editor. It will expand it to fit all content (or up
to 400px if the content was not exceeding 300px). In the expanded mode
the editor will keep growing as the user types more content.
2024-04-26 13:31:49 +02:00
f10bcb96a6 Replace Ace Editor with ToastUi editor in the ExecutionEnvironments form
Drop unused code related to the Ace markdown editor.
2024-04-26 13:31:49 +02:00
17a4485ce2 Rename PagedownFormBuilder to MarkdownFormBuilder
The term 'Pagedown' was originally associated with the pagedown-bootstrap
library, which is no longer in use.
2024-04-26 13:31:49 +02:00
0667cbeefb Drop pagedown-bootstrap library and all its related code 2024-04-26 13:31:49 +02:00
9fe18f1873 Add and customize ToastUI image insertion option
The default ToastUI image insertion feature includes both URL and file
upload options. However, file upload functionality isn't supported in
the application. This commit addresses the issue by implementing custom
code to hide the file upload button while preserving the URL insertion
option.
2024-04-26 13:31:49 +02:00
9c71c6667a Install and use ToastUi markdown editor
Replace all usages of pagedown-bootstrap editor with the new editor.
Add styles to ensure the editor preview matches the final output.
2024-04-26 13:31:49 +02:00
96f5f1f8d7 Enforce valid lis_outcome_service_url
Recently, a new institution joined CodeOcean and used a relative URL. This won't work, so that we are rejecting non-absolute URLs by now.
2024-04-26 10:21:53 +02:00
c4b7bac6c7 Fix NameError on block forward
This is a regression from 27f128ad.

Fixes CODEOCEAN-12R
2024-04-24 17:54:25 +02:00
b11b8b9e1e Fix invalid column reference for non-detailed exercise statistics
Fixes CODEOCEAN-12D
2024-04-24 17:53:27 +02:00
6e4e376c91 Fix missing linter results caused by incorrect JS loop
Fixes CODEOCEAN-FRONTEND-69
2024-04-24 17:52:46 +02:00
88c6be88f1 Fix race condition on JavaScript initializer
Previously, ProgrammingGroups could have been undefined in rare cases. Therefore, we check whether the variable is properly defined before calling the method.

Fixes CODEOCEAN-FRONTEND-7D
2024-04-24 17:23:29 +02:00
6d66376aae Fix layout for exercise description on implement route
Regresses 9a9efd5c and a7fa9b5b
2024-04-24 17:16:46 +02:00
dd7b09e1e3 Improve visual difference for solved and soft-solved RfCs 2024-04-24 12:18:47 +02:00
7cc4fb00c6 RfCs: Allow filtering for any states
We want to differentiate between those RfCs explicitly marked as solved, those potentially solved since the author reached the maximum score, and those being unsolved where the author has not yet reached the full score yet.
2024-04-24 12:18:47 +02:00
e9941d8f47 Keep indention when displaying comments 2024-04-23 22:55:20 +02:00
9a9efd5caa Lint Slim files and fix offenses
The fixing was partially done manually and partially automatically.
2024-04-18 08:31:24 +02:00
27f128ad2d Fix Rubocop offenses 2024-04-18 08:28:46 +02:00
dab8f777b3 Extract Contributor concern as abstract class
During documentation of the pair programming feature, we noticed that the Contributor should be an abstract class, which is parent for the User and the ProgrammingGroup. With this commit, we perform these changes.
2024-04-02 16:56:49 +02:00
dfa970664d Escape text passed in collection sorting
Previously, the ID and title of tips and exercises newly added to the list were gathered from the DOM. While we keep this mechanism, we ensure to escape the text before reusing it.
2024-03-28 19:05:55 +01:00
4f8d313da4 Use webpack to deliver newest ACE editor
With this commit, we change the delivery method for the ACE editor from manually copied files to using yarn and webpack. As a side-change, we also modify how the mode is selected through JavaScript instead of Ruby.

Through webpack, the `modePath`, `themePath`, and `workerPath` are automatically determined and working as expected.

Closes #250
2024-03-25 10:00:04 +01:00
942dbd20db Fix display of custom annotations in ACE Editor
With these changes, we no longer need our custom changes previously restored with 1013903.
2024-03-25 10:00:04 +01:00
e366ebd34c Resolve deprecation warnings for ACE Editor 1.32.6 2024-03-25 10:00:04 +01:00
117d3366ad fix kramdown using curved quotes and replace them with straight quotation marks 2024-03-14 17:03:00 +01:00
57073429d3 Extract choose_locale method, similar to CodeHarbor 2024-03-09 18:51:38 +01:00
04863f1f25 Update Ruby to 3.3 2024-01-19 12:49:00 +01:00
60dad19ea5 Rename .js.erb files .js
Since we switched to more I18n-JS and JsRoute functions with f5739a33 and 2f03061f, we don't have the need to use a template engine for those files any longer.
2024-01-19 11:06:40 +01:00
5b35ccdfe8 Reuse jQuery selector where possible 2024-01-19 11:06:40 +01:00
affeb2d3ba Remove obsolete user_id leftover in requestComments() 2024-01-19 11:06:40 +01:00
a9e1d491be Use safe comparison in JavaScript 2024-01-19 11:06:40 +01:00
9147482876 Use JsRoutes in .js.erb files 2024-01-19 11:06:40 +01:00
34aac83909 Use I18n-JS rather than rails-i18n in .js.erb files 2024-01-19 11:06:40 +01:00