Commit Graph

706 Commits

Author SHA1 Message Date
b0130b8fae Remove overwrite for X-Frame-Options
* With current third-party-cookies being blocked by modern
browsers, CodeOcean won't work in an iFrame anyway.
2022-09-06 11:21:37 +02:00
5b73f4df6f Refactor render_file method
* We simplify the send_data call,
* ensure to set the correct header, and
* prevent our custom MIME type detection
2022-09-06 11:21:33 +02:00
b6d8c7175b Disallow any external resources for :render_file 2022-09-06 11:20:57 +02:00
0a16f589e9 Use X-Sendfile to transmit native files and handle file uploads 2022-09-06 01:21:40 +02:00
e5d8db2796 Return propper error for anonymous users in exercises_controller
* not_authorized_for_exercise was not checking for a current_user

Fixes CODEOCEAN-C4
2022-09-04 19:13:08 +02:00
1581d658ea Simplify user search for external teachers 2022-09-04 19:03:15 +02:00
22cd202e9d Refactor reject_illegal_file_attributes check
* Improve readability of method
* Add a new check for the author of a submission
2022-09-04 11:42:36 +02:00
b67daedfc9 Remove dead code from ProxyExercise 2022-09-04 00:05:38 +02:00
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
b6837e9539 Refactor validity of token authentication 2022-09-02 16:56:19 +02:00
60dc8c3b7e Apply line-based coloring for output 2022-09-02 16:56:18 +02:00
bdebcf319e Allow access to user statistics for teachers
Fixes CODEOCEAN-BV
2022-08-25 18:14:10 +02:00
35dd745a29 Use final submission for exercise feedback
* Also, check for required permission
2022-08-24 23:56:34 +02:00
7da08d2990 Fix typo for working_time_query 2022-08-24 23:29:49 +02:00
c8c3a5bf95 Fix external user statistics for tags 2022-08-24 12:16:38 +02:00
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
166aa3cc6f Remove Ransack from Exercise edit for tags
* Also improve Ransack usage of attributes and associations
2022-08-20 01:33:00 +02:00
83feb67dd5 Update find method for study group in RfC index 2022-08-20 00:58:12 +02:00
c228850ae8 Update find method 2022-08-20 00:37:48 +02:00
6927b57170 Update Study Group Dashboard and Statistics 2022-08-20 00:05:02 +02:00
d762f976a8 Add new CodeOcean::File#read method
* With a new method, we can simplify our code to handle differences between file.content and file.native_file.read
2022-08-19 22:42:55 +02:00
a9aab612b6 Extract updating the user role from params 2022-08-18 21:44:26 +02:00
acc07ffa5d Disallow leading / in zip archives 2022-08-18 16:45:15 +02:00
3248bd74d1 Fix authorization for communitySolutionsIndex 2022-08-18 16:28:10 +02:00
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
01f6b0d16e Reduce skip_before_action usage 2022-08-17 00:54:20 +02:00
b9357bb9c7 Fix warning message for sync_to_runner_management 2022-08-16 18:18:24 +02:00
cc4003baf7 Fix rubocop offenses 2022-08-12 23:52:23 +02:00
cc7a1d7fb5 Always show autosaves if otherwise no submission would be available 2022-08-12 17:44:41 +02:00
345df747bd Prevent Runner sync errors to be reported to Sentry, increase log level 2022-08-12 17:16:21 +02:00
4615a49e62 added strong params to comments_controller to prevent users from editing attributes which are not intended to be edited, also created specs to test this behaviour 2022-08-09 14:45:16 +02:00
cc3fc72cf9 slight changes to application controller to be more readable 2022-08-05 08:05:07 +02:00
d4c567c722 Remove @submissions variable for external_user_statistics 2022-07-22 13:19:22 +02:00
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
0f84e46272 added logic to the statistics method to be able to toggle autosave submissions depending on the show_autosaves param 2022-07-20 17:18:36 +02:00
baf70a0c06 Sanitize locale input.
Closes CODEOCEAN-9E
2022-07-15 13:35:18 +02:00
9587ecb2b1 Resolve bug where duration of not-started runner cannot be calculated 2022-07-15 00:49:16 +02:00
1183f5cdcd Ensure that the testrun[:status] is available in more cases 2022-07-15 00:49:15 +02:00
0ab3d0bdc1 Fix Rubocop offenses 2022-06-30 14:02:53 +02:00
0a3b4a8129 Fix Rubocop offense 2022-06-15 17:39:20 +02:00
ee8e76af07 Remote Submit: Add remark to check submission deadline 2022-06-08 16:49:43 +02:00
ea728f54ec Fix remote evaluations URL when using subdirectory for CO 2022-05-14 19:01:54 -04:00
e4384d7ddd Merge pull request #1242 from openHPI/refactor_testrun_table
Refactor testrun table
2022-05-04 00:25:08 +02:00
2ce9c4258a Remove New Relic 2022-04-29 22:53:36 +02:00
ea02dff0e5 Extend storage of Testrun Messages and truncate long output 2022-04-29 22:44:34 +02:00
5ecba6ef70 Persist TestrunMessages and store timestamp
So far, the Testrun messages are in addition to the Tesstrun.output column
2022-04-29 01:00:51 +02:00
9a0f26a84f Allow admins and teachers to remove explicit RfC text 2022-04-28 15:31:58 +02:00
e9efb5bc2b Add exit_code and status to Testruns, create model for TestrunMessages
* This is the first step to migrate the `output` column from Testruns to a dedicated table TestrunMessages
2022-04-28 15:18:51 +02:00
5191e70462 Fix SQL for FlowrController 2022-04-20 19:12:44 +02:00
492c7e9133 Fix CookieOverflow when adding a new user 2022-04-20 18:57:26 +02:00