Commit Graph

492 Commits

Author SHA1 Message Date
e3018c1847 Refactor consumer factory 2022-09-22 19:24:26 +02:00
964048927a Updated teacher_in_study_group? method to check for common teacher role 2022-09-22 19:24:26 +02:00
936c11e31f Refactor authentication token for new study-group-based authorization 2022-09-22 19:24:26 +02:00
cb1b163b30 Always create a default study group for new consumers 2022-09-22 19:24:26 +02:00
521626275f Use create for all users in specs where necessary 2022-09-22 19:24:26 +02:00
9c9f45ff77 Redefine user roles with their role in a study group 2022-09-22 19:24:26 +02:00
ec4c6207f0 Refactor internal_users_controller_spec to prevent invalid objects 2022-09-22 19:24:26 +02:00
79571a3287 Allow build-in coverage report for RubyMine 2022-09-22 19:24:26 +02:00
7e9967e2bf Fix rubocop offenses 2022-09-16 01:03:55 +02:00
d02a1eae81 Validate password strength for internal users 2022-09-14 12:19:25 +02:00
f1aa004284 Use controller method for 404 responses 2022-09-14 01:01:14 +02:00
006c794f54 Fix rubocop offenses 2022-09-14 00:31:47 +02:00
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
5ec2c7f5bc refactor role finding logic for convert_task_to_exercise
add specs
2022-09-13 22:47:12 +02:00
0a16f589e9 Use X-Sendfile to transmit native files and handle file uploads 2022-09-06 01:21:40 +02:00
813c3f50af Touch file location before setting a symlink in specs 2022-09-04 19:15:15 +02:00
22cd202e9d Refactor reject_illegal_file_attributes check
* Improve readability of method
* Add a new check for the author of a submission
2022-09-04 11:42:36 +02:00
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
87737e50a2 Fix Rubocop offenses 2022-09-03 00:10:11 +02:00
e00d1772ca Disallow markup for RfC emails 2022-09-02 18:14:14 +02:00
9050f02b7a Add additional test case for new CodeOcean::File#read method 2022-09-02 17:52:24 +02:00
b6837e9539 Refactor validity of token authentication 2022-09-02 16:56:19 +02:00
e77223e628 Refactor send_thank_you_note method and according specs 2022-09-02 16:56:19 +02:00
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
e5879eb606 Simplify permission specs
* Remove iteration if not required
* Unify usage of parentheses for `permissions` call
2022-08-22 17:51:57 +02:00
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
d762f976a8 Add new CodeOcean::File#read method
* With a new method, we can simplify our code to handle differences between file.content and file.native_file.read
2022-08-19 22:42:55 +02:00
a9aab612b6 Extract updating the user role from params 2022-08-18 21:44:26 +02:00
7da47a7b5c Improve tests based on expectations
Amends and improves da0a682f
2022-08-18 15:40:48 +02:00
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
cb0f30768f Change HTTP links to HTTPS 2022-08-17 01:29:27 +02:00
8a055a0d68 Update Bootstrap from v4 to v5 2022-08-12 11:45:32 +02:00
6803efc023 Fix order-dependent specs
The submission spec is removed as it was useless since 66c1b992
2022-08-12 11:39:42 +02:00
4615a49e62 added strong params to comments_controller to prevent users from editing attributes which are not intended to be edited, also created specs to test this behaviour 2022-08-09 14:45:16 +02:00
b98c37ae64 Rename v4 FontAwesome icons to match v5/v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4#icons-renamed-since-version-4
2022-08-09 14:17:32 +02:00
d93e71dc28 Rename v5 FontAwesome icons to match v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/whats-changed#icons-renamed-in-version-6
2022-08-09 14:17:32 +02:00
a9039a8019 Prevent false positive for raised error 2022-08-09 11:42:06 +02:00
fa27e3923d Reimplement pending specs with rough skeleton 2022-08-09 11:41:41 +02:00
6e213f754f minor styling change to authenticationtoken model, changed the expire_at column of AuthenticationToken form date to datetime 2022-08-05 08:05:07 +02:00
1a987a65d4 added new AuthenticationToken factory, as well as new tests to check if access is denied when the token is expired, smaller optimalization changes to the user_mailer_spec and authentication_spec 2022-08-05 08:05:07 +02:00
146eee673f changed send_thank_you_note and got_new_comment_for_subscription methods to use tokens properly, as well as new test scenarios for both cases 2022-08-05 08:05:07 +02:00
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
184c9cba6d created new feature test to check that only users with the right permission are able to see the new autosave-hide feature 2022-07-20 17:18:36 +02:00
67dd8566b6 added a test scenario to check if autosave submissions are being toggled right 2022-07-20 17:18:36 +02:00
c792b99523 Fix tests for latest locale change 2022-07-15 14:02:10 +02:00
56eab88f88 Gracefully handle the deletion of non-existing runners 2022-07-15 00:49:15 +02:00
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
55937d3cc5 Ensure compatibility with Ruby 3.1 2022-06-30 17:04:24 +02:00
d3f283c4e7 Update usage of RubyTree to avoid deprecated methods 2022-06-27 12:14:55 +02:00