Commit Graph

43 Commits

Author SHA1 Message Date
Sebastian Serth
96f5f1f8d7 Enforce valid lis_outcome_service_url
Recently, a new institution joined CodeOcean and used a relative URL. This won't work, so that we are rejecting non-absolute URLs by now.
2024-04-26 10:21:53 +02:00
kiragrammel
b91a2b7ce0 Remove PairProgramming23Study and instead use LTI parameter 2023-10-22 12:07:41 +02:00
Sebastian Serth
99bd46af1a Align project files with CodeHarbor
Since both projects are developed together and by the same team, we also want to have the same code structure and utility methods available in both projects. Therefore, this commit changes many files, but without a functional change.
2023-10-11 00:18:33 +02:00
kiragrammel
c2995c96f0 Remove clear_lti_session_data as it is no longer needed
* no lti session data anymore included in the function
* decided not to delete the pg_id here as it is handled in create_through_lti and implement
* the function is only called once without an exercise id so the values are now directly deleted there
2023-08-24 19:32:06 +02:00
Sebastian Serth
e3603758ef Refactor LTI parameters and add study group
* This change also requires that submissions in our test need to have a valid study group.
2023-08-24 19:32:06 +02:00
kiragrammel
0234414bae Rename user to contributor in submission 2023-08-24 19:32:06 +02:00
Sebastian Serth
8f446c04a9 Fix Rubocop offenses 2023-07-31 08:59:00 +02:00
Sebastian Serth
bf077ef478 Fix rubocop offenses 2022-12-09 13:11:46 +01:00
Sebastian Serth
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00
Sebastian Serth
a4e791e3de Always render templates in Controller specs 2022-11-02 12:25:33 +01:00
Sebastian Serth
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
Sebastian Serth
c792b99523 Fix tests for latest locale change 2022-07-15 14:02:10 +02:00
Sebastian Serth
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
Sebastian Serth
d9f40531fb Fix Rubocop offenses 2022-04-20 18:26:53 +02:00
Sebastian Serth
ea85519163 Update bundle (with newest rubocop version) and fix offenses 2022-01-04 09:42:37 +01:00
Sebastian Serth
1b71163a77 Refactor locale with around method 2021-06-25 17:36:56 +02:00
Sebastian Serth
e7cf4ef5db Apply automatic rubocop fixes 2021-06-25 14:41:49 +02:00
Sebastian Serth
da0a682ffb Apply manual rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
ebdfd4ab63 Re-enable oscillating tests 2021-05-12 16:47:05 +02:00
Sebastian Serth
b10e23dd16 Upgrade to newest Sentry 2021-03-04 14:02:16 +01:00
Sebastian Serth
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
Sebastian Serth
758f2b3365 Adopt tests to respect Raven context 2020-01-29 09:55:35 +01:00
Sebastian Serth
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
Sebastian Serth
90defa8f89 Fix tests and rename request variable in specs to perform_request
Explanation: Using the variable name `request` might interfere with methods in Rails core system prevent successful test execution. See this issue: https://github.com/turbolinks/turbolinks-rails/issues/38
2018-11-06 16:49:42 +01:00
Sebastian Serth
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
Maximilian Grundke
6377c6ca0f Use skip instead of misused pending in oscillating tests 2018-01-31 13:06:18 +01:00
Maximilian Grundke
e934a29a45 Set oscillating tests to pending 2017-12-20 10:36:31 +01:00
Ralf Teusner
fc873cb053 second run of replacement regex from https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md ...
Nested calls seem to be fun..
2017-11-15 15:37:42 +01:00
Ralf Teusner
0e26ab98c8 rename factory_girl_(rails) to factory_bot_(rails) 2017-11-15 15:18:07 +01:00
Thomas Hille
7a61d5a983 tests 2017-03-21 10:31:32 +01:00
Thomas Hille
d5b2ea4269 added proxy exercise dispatching to LTI module. Submissions now set user before the exercise token gets validated. this we need to set the exercise behind the proxy exercise 2017-03-21 10:31:32 +01:00
Tom Staubitz
325ea25849 Replaced session[:lti_parameters] with proper LtiParameter object.
Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
2016-12-30 09:45:39 +01:00
Tom Staubitz
6f1d8b2d38 Marked more locations that might require to be changed when we switch from session to LtiParameters Object 2016-12-27 07:48:59 +01:00
Tom Staubitz
f4c01879bf preparations to replace session with lti_parameters object 2016-12-27 00:13:41 +01:00
Hauke Klement
4eef3d70d5 minor refactoring of flash messages 2015-03-23 16:42:57 +01:00
Hauke Klement
42c8b47d40 concretized redirection expectations in controller specs 2015-02-24 18:57:00 +01:00
Hauke Klement
5bfe03c426 set application locale from custom LTI launch parameter 2015-02-23 11:33:43 +01:00
Hauke Klement
466f8967e2 eliminated naming clash with Sorcery 2015-02-23 10:39:04 +01:00
Hauke Klement
b21a7ee8e8 use shorter notation for creating procs, as suggested by RuboCop 2015-02-17 08:21:00 +01:00
Hauke Klement
d38e7e1791 added tests 2015-02-09 12:25:20 +01:00
Hauke Klement
b08bc8aef2 sped up some tests 2015-01-30 10:50:44 +01:00
Hauke Klement
4cbf9970b1 transferred Code Ocean from original repository to GitHub 2015-01-22 10:01:32 +01:00