Commit Graph

361 Commits

Author SHA1 Message Date
Sebastian Serth
e5879eb606 Simplify permission specs
* Remove iteration if not required
* Unify usage of parentheses for `permissions` call
2022-08-22 17:51:57 +02:00
Janis4411
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
Sebastian Serth
d762f976a8 Add new CodeOcean::File#read method
* With a new method, we can simplify our code to handle differences between file.content and file.native_file.read
2022-08-19 22:42:55 +02:00
Sebastian Serth
a9aab612b6 Extract updating the user role from params 2022-08-18 21:44:26 +02:00
Sebastian Serth
7da47a7b5c Improve tests based on expectations
Amends and improves da0a682f
2022-08-18 15:40:48 +02:00
Sebastian Serth
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
Sebastian Serth
cb0f30768f Change HTTP links to HTTPS 2022-08-17 01:29:27 +02:00
Sebastian Serth
8a055a0d68 Update Bootstrap from v4 to v5 2022-08-12 11:45:32 +02:00
Sebastian Serth
6803efc023 Fix order-dependent specs
The submission spec is removed as it was useless since 66c1b992
2022-08-12 11:39:42 +02:00
Janis4411
4615a49e62 added strong params to comments_controller to prevent users from editing attributes which are not intended to be edited, also created specs to test this behaviour 2022-08-09 14:45:16 +02:00
Sebastian Serth
b98c37ae64 Rename v4 FontAwesome icons to match v5/v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4#icons-renamed-since-version-4
2022-08-09 14:17:32 +02:00
Sebastian Serth
d93e71dc28 Rename v5 FontAwesome icons to match v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/whats-changed#icons-renamed-in-version-6
2022-08-09 14:17:32 +02:00
Sebastian Serth
a9039a8019 Prevent false positive for raised error 2022-08-09 11:42:06 +02:00
Sebastian Serth
fa27e3923d Reimplement pending specs with rough skeleton 2022-08-09 11:41:41 +02:00
Janis4411
6e213f754f minor styling change to authenticationtoken model, changed the expire_at column of AuthenticationToken form date to datetime 2022-08-05 08:05:07 +02:00
Janis4411
1a987a65d4 added new AuthenticationToken factory, as well as new tests to check if access is denied when the token is expired, smaller optimalization changes to the user_mailer_spec and authentication_spec 2022-08-05 08:05:07 +02:00
Janis4411
146eee673f changed send_thank_you_note and got_new_comment_for_subscription methods to use tokens properly, as well as new test scenarios for both cases 2022-08-05 08:05:07 +02:00
Sebastian Serth
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
Janis4411
184c9cba6d created new feature test to check that only users with the right permission are able to see the new autosave-hide feature 2022-07-20 17:18:36 +02:00
Janis4411
67dd8566b6 added a test scenario to check if autosave submissions are being toggled right 2022-07-20 17:18:36 +02:00
Sebastian Serth
c792b99523 Fix tests for latest locale change 2022-07-15 14:02:10 +02:00
Sebastian Serth
56eab88f88 Gracefully handle the deletion of non-existing runners 2022-07-15 00:49:15 +02:00
Sebastian Serth
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
Sebastian Serth
55937d3cc5 Ensure compatibility with Ruby 3.1 2022-06-30 17:04:24 +02:00
Sebastian Serth
d3f283c4e7 Update usage of RubyTree to avoid deprecated methods 2022-06-27 12:14:55 +02:00
Sebastian Serth
0a3b4a8129 Fix Rubocop offense 2022-06-15 17:39:20 +02:00
Sebastian Serth
8e403ff65a Poseidon: Use relative path to remove workspace directory
See #1088
2022-06-10 18:13:11 +02:00
Sebastian Serth
b613267add Remove legacy DockerClient 2022-06-08 13:18:37 +02:00
Sebastian Serth
ea02dff0e5 Extend storage of Testrun Messages and truncate long output 2022-04-29 22:44:34 +02:00
Sebastian Serth
038864e4b4 Fix Rubocop offenses 2022-04-24 18:18:16 +02:00
Sebastian Serth
d9f40531fb Fix Rubocop offenses 2022-04-20 18:26:53 +02:00
Sebastian Serth
b2656bd6b5 Fix rubocop offenses 2022-03-01 15:35:08 +01:00
Sebastian Serth
ea85519163 Update bundle (with newest rubocop version) and fix offenses 2022-01-04 09:42:37 +01:00
Sebastian Serth
563e14a44a Adapt dashboard to show idle and used runners 2021-12-07 00:08:31 +01:00
Sebastian Serth
f22db22110 Enable Poseidon sync after commit 2021-11-26 01:00:31 +01:00
Sebastian Serth
86c6ad7ea3 Poseidon: Use absolute path to remove workspace directory 2021-11-17 17:44:09 +01:00
Sebastian Serth
3608856397 Merge pull request #1079 from openHPI/sync_execution_environments
Sync execution environments
2021-11-09 18:44:35 +01:00
Sebastian Serth
fb92d382ac Skip verification of Docker image if pool size is empty 2021-11-09 17:49:51 +01:00
Sebastian Serth
1dce6c59ab Add note about default ACL for Docker mount dir 2021-11-08 22:39:10 +01:00
Sebastian Serth
b179dadce6 Mock CodeOcean::Config for Poseidon strategy 2021-11-04 20:09:20 +01:00
Sebastian Serth
79e8caea45 Remove outdated execution environments after syncing all 2021-11-04 20:09:20 +01:00
Sebastian Serth
c1ac401a49 Add retries to working_docker_image?
* Also synchronize images during save
2021-11-04 20:09:19 +01:00
Sebastian Serth
ecf470bddd Refactor sync_environment methods
* Add delete_environment method
* Change return value to allow raising an exception
2021-11-04 20:06:40 +01:00
Sebastian Serth
7f47af99cb Fix order-dependent specs 2021-11-04 19:15:33 +01:00
Sebastian Serth
dcafbb9d46 DCP: Change HTTP verbs 2021-11-01 17:13:12 +01:00
Sebastian Serth
1609bd2e0e Change default of raise_exception for execute_command 2021-11-01 17:13:11 +01:00
Sebastian Serth
01ec9343cf Remove usage of DockerClient 2021-11-01 17:13:10 +01:00
Sebastian Serth
2551ea709b Remove 'previous' DockerContainerPool implementation 2021-11-01 17:13:09 +01:00
Sebastian Serth
9d833e37b3 Use Net::HTTP::Persistent for requests to Poseidon 2021-11-01 17:13:09 +01:00
Sebastian Serth
25b007dfda [Spec] Fix return value of image_tags for mocked DockerClient 2021-11-01 17:13:09 +01:00