Commit Graph

228 Commits

Author SHA1 Message Date
c29256aa81 Fix Rubocop offenses 2023-09-11 14:10:16 +02:00
79422225a8 Add events for pair programming study 2023-09-05 22:56:51 +02:00
7aeca0078f Reduce N+1 queries for ExercisesController#feedback
Fixes CODEOCEAN-TF
2023-08-30 18:46:09 +02:00
235bf771fe Always use user object instead of ID and Type 2023-08-26 00:39:47 +02:00
3f674d3687 Prevent accessing another exercise during a programming group session 2023-08-24 19:32:06 +02:00
be4f2b790d Add user to testrun
* We want to identify a user that has triggered a testrun. Previously (in regular operation), only submission author who were regular users were able to start a testrun. Now, we want to prepare a future where submission authors are programming groups. Still, a testrun is triggered by an individual user and not a group.
* Further, this commit fixes some missing foreign key constrains.
2023-08-24 19:32:06 +02:00
e3603758ef Refactor LTI parameters and add study group
* This change also requires that submissions in our test need to have a valid study group.
2023-08-24 19:32:06 +02:00
e2baa2ee55 Send score for all members of a programming group 2023-08-24 19:32:06 +02:00
319c3ab3b4 Add ProgrammingGroup & ProgrammingGroupMembership
* User can create programming group with other users for exercise
* Submission is shared in a group
* Also adjust specs
2023-08-24 19:32:06 +02:00
0234414bae Rename user to contributor in submission 2023-08-24 19:32:06 +02:00
245c3dba8c Update from proforma to proformaxml 2023-08-24 00:14:41 +02:00
28a4b672f9 Remove legacy save search endpoint 2023-07-28 13:18:39 +02:00
01f4f0c2cd Remove legacy CodePilot integration 2023-07-28 08:50:00 +02:00
bf662ecb81 Remove legacy forum search and search buttons 2023-07-28 08:45:05 +02:00
b79f0015ad Fix rubocop offenses 2023-04-03 15:08:30 +02:00
72ca8c57de Reduce SQL queries for querying tips.
Closes CODEOCEAN-KY
2023-04-02 17:11:53 +02:00
a7cd85507e Reduce SQL queries in the exercise controller
Fixes CODEOCEAN-JK
2023-03-14 20:58:21 +01:00
326b5fce51 Allow assigning tips during exercise create
Fixes CODEOCEAN-H6
2023-02-16 11:23:52 +01:00
596a04b9da Handle ReadTimeouts for LTI consumer properly 2023-02-16 10:12:05 +01:00
234a4fe02b Deny /implement without execution environment
Also, fix a smaller typo in the locales
2023-01-20 23:53:08 +01:00
87771b905a Fix rubocop offenses 2023-01-11 23:57:29 +01:00
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00
dd1f4b0ac8 Merge pull request #939 from openHPI/refactor_proforma_import_export
Refactor Proforma Import/Export
2022-10-26 17:58:48 +02:00
c75f52f2c8 Fix Rubocop offenses 2022-10-24 12:28:50 +02:00
b866221353 rename route 2022-09-24 21:08:18 +02:00
fa6527b4ed Refactor exercises_controller.rb to reduce code duplication 2022-09-22 19:24:26 +02:00
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
e5d8db2796 Return propper error for anonymous users in exercises_controller
* not_authorized_for_exercise was not checking for a current_user

Fixes CODEOCEAN-C4
2022-09-04 19:13:08 +02:00
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
6094767a65 - rename parameter to be more generic
- fix splatting of service args
- add file role depending on parent object of file
- add default feedback_message for imports
2022-08-20 22:17:20 +02:00
166aa3cc6f Remove Ransack from Exercise edit for tags
* Also improve Ransack usage of attributes and associations
2022-08-20 01:33:00 +02:00
c228850ae8 Update find method 2022-08-20 00:37:48 +02:00
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
01f6b0d16e Reduce skip_before_action usage 2022-08-17 00:54:20 +02:00
cc4003baf7 Fix rubocop offenses 2022-08-12 23:52:23 +02:00
cc7a1d7fb5 Always show autosaves if otherwise no submission would be available 2022-08-12 17:44:41 +02:00
d4c567c722 Remove @submissions variable for external_user_statistics 2022-07-22 13:19:22 +02:00
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
0f84e46272 added logic to the statistics method to be able to toggle autosave submissions depending on the show_autosaves param 2022-07-20 17:18:36 +02:00
0a3b4a8129 Fix Rubocop offense 2022-06-15 17:39:20 +02:00
2ce9c4258a Remove New Relic 2022-04-29 22:53:36 +02:00
2f86b18fd6 Fix run and score statistics for internal and external users 2022-01-21 13:13:52 +01:00
11c3a888c2 Fix rubocop offenses 2022-01-19 08:57:07 +01:00
21009c7eaa Fix exercise statistics when external users share the same ID as internal users 2022-01-13 16:02:25 +01:00
0a6ae91db8 Introduce per_page parameter for custom page size 2022-01-12 20:46:54 +01:00
c5c47715b3 Merge branch 'master' into refactor_proforma_import_export
# Conflicts:
#	spec/controllers/exercises_controller_spec.rb
2022-01-11 22:20:18 +01:00
3260d8f82f tiny refactor from exercise_found to task_found 2022-01-11 22:17:09 +01:00