Commit Graph

463 Commits

Author SHA1 Message Date
c29256aa81 Fix Rubocop offenses 2023-09-11 14:10:16 +02:00
97764bd02e Limit programming groups to two people
* adapt text on programming_groups/new site
* in German change from 'Sie' to 'du'
2023-09-05 22:56:51 +02:00
235bf771fe Always use user object instead of ID and Type 2023-08-26 00:39:47 +02:00
89afb599e4 Apply changes from team members in own editor 2023-08-26 00:38:58 +02:00
c2995c96f0 Remove clear_lti_session_data as it is no longer needed
* no lti session data anymore included in the function
* decided not to delete the pg_id here as it is handled in create_through_lti and implement
* the function is only called once without an exercise id so the values are now directly deleted there
2023-08-24 19:32:06 +02:00
01accdae58 Use author_in_programming_group? policy for files & RfCs
* Allow all members of a programming group to list and solve RfCs
* Also adjust policy specs to respect programming groups
2023-08-24 19:32:06 +02:00
a1941336d9 Fix Runner access for programming groups
* We also rename the corresponding columns in the Runner model, so that for polymorphic association gets clear.
2023-08-24 19:32:06 +02:00
be4f2b790d Add user to testrun
* We want to identify a user that has triggered a testrun. Previously (in regular operation), only submission author who were regular users were able to start a testrun. Now, we want to prepare a future where submission authors are programming groups. Still, a testrun is triggered by an individual user and not a group.
* Further, this commit fixes some missing foreign key constrains.
2023-08-24 19:32:06 +02:00
e3603758ef Refactor LTI parameters and add study group
* This change also requires that submissions in our test need to have a valid study group.
2023-08-24 19:32:06 +02:00
e2baa2ee55 Send score for all members of a programming group 2023-08-24 19:32:06 +02:00
319c3ab3b4 Add ProgrammingGroup & ProgrammingGroupMembership
* User can create programming group with other users for exercise
* Submission is shared in a group
* Also adjust specs
2023-08-24 19:32:06 +02:00
0234414bae Rename user to contributor in submission 2023-08-24 19:32:06 +02:00
97138288f4 Delete unused LTI params from session 2023-08-24 19:32:06 +02:00
245c3dba8c Update from proforma to proformaxml 2023-08-24 00:14:41 +02:00
f15d4fe437 Improve comments controller spec
For this test, we had a bug so that the test could passed if executed, so that the file just had ID 50 randomly.
2023-08-01 16:22:47 +02:00
8f446c04a9 Fix Rubocop offenses 2023-07-31 08:59:00 +02:00
28a4b672f9 Remove legacy save search endpoint 2023-07-28 13:18:39 +02:00
fd2d94568a Handle OutOfMemory runner errors with gVisor 2023-07-21 16:38:49 +02:00
e097036296 Fix RfC Visibility to work as intended
The RfC Visibility of a consumer is intended to restrict who can access which RfCs. So far, those restrictions were only applied one way, for learners of a restricted consumer to view other (external) RfCs. However, the other way around should also work: If a RfC was created as part of a restricted consumer, no other external user should be able to interfere with this RfC. This commit, therefore, adds this direction as well and covers both directions with tests.
2023-07-13 11:02:10 +02:00
19ec6540e1 Fix wait_for_ajax for feature specs 2023-06-28 15:36:51 +02:00
1296a12a6d Language Selector: Prevent duplicate locale= keys 2023-06-23 22:21:56 +02:00
f36e7673ec Specs: Disable external requests with WebMock 2023-06-23 22:20:04 +02:00
06d69d8eb8 Explicitly disable feedback in submit test scenarios 2023-06-23 22:20:04 +02:00
1b21e2cd26 Explicitly disable the runner management for the dashboard test 2023-06-23 22:20:04 +02:00
ccbf41005b Always clear runner strategy after each test case
Otherwise, we get different test results depending on the test order.
2023-06-23 22:20:04 +02:00
d1a0012d4f Overwrite Bootstrap Link Renderer for WillPaginate
Without this fix, the new will_paginate version is not compatible with the old version of bootstrap-will_paginate. This issue is also tracked here: https://github.com/mislav/will_paginate/issues/649

Fixes CODEOCEAN-QK
2023-06-14 14:43:18 +02:00
bcdc71021e Fix Rubocop offenses 2023-06-11 20:46:45 +02:00
ccaf49acd5 Update action_mailer.yml configuration and adapt specs 2023-04-14 15:55:08 +02:00
939b31967f Reduce SQL queries for score runs
Fixes CODEOCEAN-JR
2023-03-14 13:56:23 +01:00
3f5ef1caf2 Mock health check for Runner management 2023-03-13 23:52:59 +01:00
7f0f2a64d1 Fix rubocop offenses 2023-03-13 13:34:02 +01:00
05a8e307ce Fix rubocop offenses 2023-02-27 11:09:34 +01:00
896f1dcbee Minimize test setup for RfC feature specs 2023-02-20 23:47:06 +01:00
76f592c88d Consider RfC visibility to view / change RfCs 2023-02-20 23:47:06 +01:00
9c3392b324 Add consumer-based RfC Visibility settings
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
9ae6a1a79d Disable focus filter for rspec 2023-02-18 21:10:47 +01:00
04a69691e0 Disable debug output during testing 2023-02-18 20:48:55 +01:00
8a47310177 Fix selenium deprecations 2023-02-18 20:31:12 +01:00
9c3ec3c7ff Refactor submission scoring and testing
* Properly cancel code execution if running is prohibited
* Correctly monitor duration with Sentry
* Align methods with running submissions
2023-02-17 18:13:48 +01:00
4b4942ef08 Seeds: Increase memory limit for Java 8 environment 2023-02-15 19:11:48 +01:00
90d713a1d4 fix (potential) problems with empty file_extensions 2023-02-09 18:42:24 +01:00
637f872f34 add file_extension validation for file_type 2023-02-09 18:42:24 +01:00
454b34275c fix file_type selection for Makefile 2023-02-09 18:42:24 +01:00
2679f5fa56 Allow random selection for ProxyExercise 2023-01-20 21:02:20 +01:00
afe7428a6f Ensure upload directory exists for symlink test 2023-01-16 11:16:03 +01:00
bf077ef478 Fix rubocop offenses 2022-12-09 13:11:46 +01:00
838019343e ProFormA: Hide 'delayed' files by default 2022-12-08 10:57:36 +01:00
9977e1614b Allow external redirect for render host and LTI
We only use the `launch_presentation_return_url` provided to the @provider, in order to prevent using an open redirect.
2022-12-05 22:38:13 +01:00
ffe96d9223 Remove I18n.translation_present? monkey patch 2022-12-04 15:03:28 +01:00
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00