Commit Graph

344 Commits

Author SHA1 Message Date
Sebastian Serth
635b9aa16f Fix RSpec/FactoryBot/FactoryClassName offenses automatically
* Fixed with `rubocop -a --only RSpec/FactoryBot/FactoryClassName`
2021-02-12 00:17:49 +01:00
Sebastian Serth
0739e13b78 Fix LTI spec for clear_lti_session_data 2021-02-02 11:53:01 +01:00
Sebastian Serth
bc05a363f2 Fix spec for InternalUser#forgot_password 2021-01-27 18:40:53 +01:00
Maximilian Pass
028fc2989a #18 Add sql index for unpublished exercises
And remove spec for remove feature
2020-12-15 12:17:11 +01:00
Sebastian Serth
f5492ca35d Improve CodeOcean::FilePolicy with specs 2020-12-07 14:41:30 +01:00
Sebastian Serth
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
Sebastian Serth
5fdfb12e62 Add German translations for PyLint adapter with basic spec 2020-11-08 01:04:39 +01:00
Sebastian Serth
da064efef7 Merge pull request #771 from openHPI/add_handling_missing_file_type_on_import
Add handling for missing file type on import
2020-11-02 19:44:51 +01:00
Karol
f872cf73ee Review points, specs 2020-11-02 17:09:31 +01:00
Karol
835b70b000 fix typo 2020-10-29 18:22:33 +01:00
Karol
517886ea0b fix codeharbor_export policies, add specs 2020-10-29 18:06:14 +01:00
Sebastian Serth
be3ec82bd4 Add new file role teacher_defined_linter 2020-10-15 00:43:57 +02:00
Karol
a5416758eb fix specs broken by rubyzip upgrade (enforce encoding) 2020-10-12 14:34:14 +00:00
Karol
6e11f29fdf fix ajax action access, dont use delayed for model_solutions 2020-10-06 15:02:27 +00:00
Sebastian Serth
66c1b99230 Fix spec for user redirect
* Very simple fix. I could also remove the test but as long as we still consider to switch back to the original implementation, I leave it here for now.
2020-09-28 19:17:30 +02:00
Sebastian Serth
fae60a21e5 Sync DockerClient with DockerContainerPool
Fix failing specs after upgrade
2020-09-28 16:53:15 +02:00
Sebastian Serth
afafe0c218 Adjust teacher permissions:
* Hide non-public exercises and proxy exercises
* Hide average working time value on statistic page
* Add hint about filter to submission page for teachers
* Hide display name from feedback page
2020-09-07 19:04:34 +02:00
Sebastian Serth
df8ea4045c Fix spec 2020-05-12 18:20:29 +02:00
Sebastian Serth
564b249e50 Refactor send_score to have access to the submission 2020-05-12 17:51:07 +02:00
Sebastian Serth
914eeb6035 Add submission deadline to exercises and allow teachers to view their submissions 2020-05-07 21:23:27 +02:00
Sebastian Serth
31500bf297 Fix final failing spec 2020-04-14 15:32:05 +02:00
Sebastian Serth
28d40605c8 Fix specs 2020-04-14 15:20:15 +02:00
Sebastian Serth
f2c45b2488 Add more LTI debug messages 2020-03-04 19:37:05 +01:00
Sebastian Serth
758f2b3365 Adopt tests to respect Raven context 2020-01-29 09:55:35 +01:00
Karol
f49cd0bed4 forbid users to import an exercise they do not have access to (previously a new one was created) 2019-12-18 17:52:34 +01:00
Karol
7d4c4a4494 remove checksum 2019-12-16 17:43:47 +01:00
Karol
da8d31279c review points 2019-12-16 17:38:32 +01:00
Karol
1ddd6e19f5 add transaction spec 2019-12-14 12:34:55 +01:00
Karol
f680916385 remove create_new functionality, when exercise exists on CH but is not editable 2019-12-13 16:43:19 +01:00
Karol
06053d437d add specs for nil paths 2019-12-10 16:37:36 +01:00
Karol
4fd440b1f6 reenable webrequests in specs 2019-12-09 20:50:42 +01:00
Karol
46e7853465 specs for services 2019-12-09 20:35:49 +01:00
Karol
c89ee6c102 model and policy specs 2019-12-07 13:11:48 +01:00
Karol
5625fa63b0 add controller specs 2019-12-06 17:25:00 +01:00
Sebastian Serth
924f94f254 Fix failing tests for new permissions 2019-11-29 15:50:50 +01:00
Sebastian Serth
a088e4c9f6 Update Bundle and ignore failing specs 2019-11-29 11:28:26 +01:00
Karol
4bea81be31 add spec to satisfy codeclimate 2019-06-16 16:08:48 +02:00
Ralf Teusner
f89d740671 fix test 2019-03-29 15:46:42 +01:00
Sebastian Serth
7f1a7fbaa0 Fix error in displaying JStree and revert new default for FactoryBot 2019-03-11 23:43:02 +01:00
Sebastian Serth
d95cf1cffb Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/controllers/concerns/lti.rb
2018-12-19 01:44:34 +01:00
rteusner
2c29bf4e2b Merge branch 'master' into add_groups 2018-12-14 00:57:26 +01:00
Sebastian Serth
1a26d67c82 Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/views/application/_breadcrumbs.html.slim
#	app/views/application/welcome.html.slim
#	app/views/exercise_collections/show.html.slim
#	app/views/external_users/index.html.slim
#	app/views/layouts/application.html.slim
#	app/views/proxy_exercises/index.html.slim
#	app/views/user_exercise_feedbacks/index.html.slim
#	app/views/user_mailer/send_thank_you_note.slim
2018-12-14 00:53:06 +01:00
rteusner
6c46566174 Merge pull request #242 from openHPI/fix_proxy_exercise
Add user (ID and type) to proxy exercise
2018-12-13 16:23:51 +01:00
rteusner
ff701e52bb Merge pull request #244 from openHPI/specify_embed_options
Implement support for some basic embed options for work sheets via LTI
2018-12-13 16:21:55 +01:00
Sebastian Serth
88081bb541 Replace usage of name in favor of displayname 2018-12-13 14:27:55 +01:00
Sebastian Serth
3665058435 Fix tests and slightly refactor some policies 2018-12-12 14:09:20 +01:00
Sebastian Serth
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
Sebastian Serth
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
Sebastian Serth
59257d17f2 Add user (ID and type) to proxy exercise
This is required for the existing policies to work
2018-12-06 00:31:45 +01:00
Sebastian Serth
56c59a616e Completely remove old non-structured errors and migrate existing ones. 2018-11-30 11:27:25 +01:00