Commit Graph

67 Commits

Author SHA1 Message Date
Sebastian Serth
596a04b9da Handle ReadTimeouts for LTI consumer properly 2023-02-16 10:12:05 +01:00
Sebastian Serth
bec235c8d6 Fix XML parsing with invalid LTI response
An invalid XML response may be returned if the LTI provider is unavailable and cannot handle our request. We decided against logging in Sentry as this affects a third party functionality we cannot fix ourselves.
Fixes CODEOCEAN-G2
2022-12-07 23:00:21 +01:00
Sebastian Serth
9977e1614b Allow external redirect for render host and LTI
We only use the `launch_presentation_return_url` provided to the @provider, in order to prevent using an open redirect.
2022-12-05 22:38:13 +01:00
Sebastian Serth
4f0b8c3c42 Reduce usage of @current_user (use helper instead) 2022-11-02 12:27:38 +01:00
Sebastian Serth
9c9f45ff77 Redefine user roles with their role in a study group 2022-09-22 19:24:26 +02:00
Sebastian Serth
2ce9c4258a Remove New Relic 2022-04-29 22:53:36 +02:00
Sebastian Serth
61d3bffe1a Keep LTI parameters after submitting through the web interface 2022-03-16 13:46:47 +01:00
Sebastian Serth
5243808d54 Apply automatic rubocop fixes 2021-05-17 19:40:38 +02:00
Sebastian Serth
da0a682ffb Apply manual rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
6cbecb5b39 Apply automatic rubocop fixes 2021-05-14 22:03:06 +02:00
Sebastian Serth
b10e23dd16 Upgrade to newest Sentry 2021-03-04 14:02:16 +01:00
Sebastian Serth
0f55c64ddd Refactor LTI study group assignment 2021-02-16 22:01:11 +01:00
Sebastian Serth
a5da0eb91e Delete study_group_id for LTI users on sign out 2021-02-01 15:56:23 +01:00
Sebastian Serth
6900d4ef2c Add collapse_exercise_description LTI parameter 2021-01-29 13:54:47 +01:00
Sebastian Serth
423a5b08f9 Allow internal user to be part of an study group 2021-01-11 14:22:50 +01:00
Sebastian Serth
c32e7586cd Remove consumer_id from session
* Each external (and also internal) user has a consumer attached. We don't need that information twice.
2020-11-25 21:19:18 +01:00
Sebastian Serth
993fb88f03 Enable submit via API client 2020-11-25 20:47:28 +01:00
Sebastian Serth
1b5d1d3dca Reduce score sent via LTI if too late 2020-10-28 11:58:40 +01:00
Sebastian Serth
4ee1f3aada Remove teacher access for informatiktag2020 2020-09-09 10:17:46 +02:00
Sebastian Serth
6cae31ae8d Allow teacher access for informatiktag2020 2020-09-09 10:17:17 +02:00
Sebastian Serth
5547ff5ac5 Fix comment 2020-05-12 17:54:37 +02:00
Sebastian Serth
564b249e50 Refactor send_score to have access to the submission 2020-05-12 17:51:07 +02:00
Sebastian Serth
ff0b72ead4 Always use last LtiParamters if multiple are stored.
Still unsure, how that could happen. We want to prevent that
2020-03-19 22:19:05 +01:00
Sebastian Serth
42d5480167 Ensure to clear LTI session once the score is submitted 2020-03-06 16:32:31 +01:00
Sebastian Serth
b63280ff97 Increase performace for studyGroup membership 2020-03-05 11:59:25 +01:00
Sebastian Serth
ca1dd0e7dd Add more info for ReadTimeout issues 2020-03-05 10:38:00 +01:00
Sebastian Serth
f2c45b2488 Add more LTI debug messages 2020-03-04 19:37:05 +01:00
Sebastian Serth
58031587de Check @exercise prior usage 2020-03-04 17:57:45 +01:00
Sebastian Serth
dbfc1b2e11 Add additional logging for Sentry 2020-03-04 17:42:07 +01:00
Sebastian Serth
7b00bb483e Allow different StudyGroup names in CodeOcean than on MOOC platforms 2020-03-04 10:57:01 +01:00
Sebastian Serth
67af04f82d Revert "Prevent updating the user role for LTI launches"
This reverts commit d9770396
2020-02-03 11:37:38 +01:00
Sebastian Serth
d977039699 Prevent updating the user role for LTI launches 2020-02-02 12:35:24 +01:00
Sebastian Serth
6d16dfe14d Add embed options to disable redirect to either rfcs or feedback 2020-01-15 14:39:36 +01:00
Sebastian Serth
baa0784ede Add custom_embed_option to disallow downloading submissions 2019-03-29 14:56:14 +01:00
Sebastian Serth
6e03939c10 Add StudyGroup to submissions and show it for submissions and RfCs
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
Sebastian Serth
9087d42088 Fix usage of incorrect downcase method 2018-12-19 19:47:16 +01:00
rteusner
ac7e41d8b3 Merge pull request #248 from openHPI/improve_groups
Improve groups with a view and always create a group
2018-12-19 13:57:41 +01:00
Sebastian Serth
d95cf1cffb Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/controllers/concerns/lti.rb
2018-12-19 01:44:34 +01:00
Sebastian Serth
c0608b6f50 Don't set admin privileges through LTI 2018-12-19 01:43:37 +01:00
Sebastian Serth
7dc83065eb Create study groups for every LTI launch 2018-12-14 15:11:50 +01:00
rteusner
2c29bf4e2b Merge branch 'master' into add_groups 2018-12-14 00:57:26 +01:00
Sebastian Serth
1a26d67c82 Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/views/application/_breadcrumbs.html.slim
#	app/views/application/welcome.html.slim
#	app/views/exercise_collections/show.html.slim
#	app/views/external_users/index.html.slim
#	app/views/layouts/application.html.slim
#	app/views/proxy_exercises/index.html.slim
#	app/views/user_exercise_feedbacks/index.html.slim
#	app/views/user_mailer/send_thank_you_note.slim
2018-12-14 00:53:06 +01:00
Sebastian Serth
3665058435 Fix tests and slightly refactor some policies 2018-12-12 14:09:20 +01:00
Sebastian Serth
71fd3b9b07 Add role to ExternalUser and update it via LTI 2018-12-12 14:09:19 +01:00
Sebastian Serth
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
Sebastian Serth
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
Sebastian Serth
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
Ralf Teusner
8d1c846fae changes to newrelic 2017-09-20 13:29:26 +02:00
Ralf Teusner
ce2823e871 restrict name to be set to lis_person_name_full (should be display name) or to lis_person_name_given (should be first name).
don't use xikolo api any longer for consumer openHPI, use the values in CodeOcean.
2017-04-03 15:26:02 +02:00
Thomas Hille
12adfde6c2 search bar now searches in forum of the course from where the LTI request came from. alternatively searches in the java 2017 course.
show interventions only in the current java course
2017-03-21 10:31:45 +01:00