Commit Graph

170 Commits

Author SHA1 Message Date
e767cff309 Fix flaky tests dependent on exercise.reload for files 2023-09-16 16:57:59 +02:00
c2995c96f0 Remove clear_lti_session_data as it is no longer needed
* no lti session data anymore included in the function
* decided not to delete the pg_id here as it is handled in create_through_lti and implement
* the function is only called once without an exercise id so the values are now directly deleted there
2023-08-24 19:32:06 +02:00
e3603758ef Refactor LTI parameters and add study group
* This change also requires that submissions in our test need to have a valid study group.
2023-08-24 19:32:06 +02:00
e2baa2ee55 Send score for all members of a programming group 2023-08-24 19:32:06 +02:00
319c3ab3b4 Add ProgrammingGroup & ProgrammingGroupMembership
* User can create programming group with other users for exercise
* Submission is shared in a group
* Also adjust specs
2023-08-24 19:32:06 +02:00
0234414bae Rename user to contributor in submission 2023-08-24 19:32:06 +02:00
245c3dba8c Update from proforma to proformaxml 2023-08-24 00:14:41 +02:00
f15d4fe437 Improve comments controller spec
For this test, we had a bug so that the test could passed if executed, so that the file just had ID 50 randomly.
2023-08-01 16:22:47 +02:00
8f446c04a9 Fix Rubocop offenses 2023-07-31 08:59:00 +02:00
fd2d94568a Handle OutOfMemory runner errors with gVisor 2023-07-21 16:38:49 +02:00
06d69d8eb8 Explicitly disable feedback in submit test scenarios 2023-06-23 22:20:04 +02:00
1b21e2cd26 Explicitly disable the runner management for the dashboard test 2023-06-23 22:20:04 +02:00
ccbf41005b Always clear runner strategy after each test case
Otherwise, we get different test results depending on the test order.
2023-06-23 22:20:04 +02:00
3f5ef1caf2 Mock health check for Runner management 2023-03-13 23:52:59 +01:00
7f0f2a64d1 Fix rubocop offenses 2023-03-13 13:34:02 +01:00
05a8e307ce Fix rubocop offenses 2023-02-27 11:09:34 +01:00
9c3392b324 Add consumer-based RfC Visibility settings
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
9c3ec3c7ff Refactor submission scoring and testing
* Properly cancel code execution if running is prohibited
* Correctly monitor duration with Sentry
* Align methods with running submissions
2023-02-17 18:13:48 +01:00
bf077ef478 Fix rubocop offenses 2022-12-09 13:11:46 +01:00
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00
a4e791e3de Always render templates in Controller specs 2022-11-02 12:25:33 +01:00
dd1f4b0ac8 Merge pull request #939 from openHPI/refactor_proforma_import_export
Refactor Proforma Import/Export
2022-10-26 17:58:48 +02:00
c75f52f2c8 Fix Rubocop offenses 2022-10-24 12:28:50 +02:00
f7515362a1 Set Content-Type to fixed value for all download actions 2022-10-05 21:46:17 +02:00
3263d4f838 Respect subpath for (render_)protected_upload_path 2022-09-28 11:06:15 +02:00
b866221353 rename route 2022-09-24 21:08:18 +02:00
16c00ec136 Add support for signed URLs used by the render_file function 2022-09-23 21:35:22 +02:00
5881795d5f Memorize config options instead of reading them from file over and over again 2022-09-23 21:35:22 +02:00
e3018c1847 Refactor consumer factory 2022-09-22 19:24:26 +02:00
ec4c6207f0 Refactor internal_users_controller_spec to prevent invalid objects 2022-09-22 19:24:26 +02:00
7e9967e2bf Fix rubocop offenses 2022-09-16 01:03:55 +02:00
d02a1eae81 Validate password strength for internal users 2022-09-14 12:19:25 +02:00
f1aa004284 Use controller method for 404 responses 2022-09-14 01:01:14 +02:00
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
0a16f589e9 Use X-Sendfile to transmit native files and handle file uploads 2022-09-06 01:21:40 +02:00
49f4f0e6c5 Refactor exercise_controller and move more checks to policy
* We introduce a custom handler for Pundit::NotAuthorizedError
2022-09-04 00:05:13 +02:00
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
e0c2c7b806 Hide score button if exercise has no tests
We check for all teacher-defined assessments (linter and unit tests) to determine whether scoring should be possible
2022-08-22 17:51:57 +02:00
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
d762f976a8 Add new CodeOcean::File#read method
* With a new method, we can simplify our code to handle differences between file.content and file.native_file.read
2022-08-19 22:42:55 +02:00
a9aab612b6 Extract updating the user role from params 2022-08-18 21:44:26 +02:00
145c4aa8d5 Refactor various ruby files
* Insights based on brakeman report
2022-08-18 15:25:04 +02:00
cb0f30768f Change HTTP links to HTTPS 2022-08-17 01:29:27 +02:00
4615a49e62 added strong params to comments_controller to prevent users from editing attributes which are not intended to be edited, also created specs to test this behaviour 2022-08-09 14:45:16 +02:00
fa27e3923d Reimplement pending specs with rough skeleton 2022-08-09 11:41:41 +02:00
2141fdb1ac Refactor external_user_statistics to own controller action 2022-07-22 13:19:22 +02:00
67dd8566b6 added a test scenario to check if autosave submissions are being toggled right 2022-07-20 17:18:36 +02:00
c792b99523 Fix tests for latest locale change 2022-07-15 14:02:10 +02:00
5e9bf9141c Fix Rubocop offenses 2022-07-08 15:23:55 +02:00
d9f40531fb Fix Rubocop offenses 2022-04-20 18:26:53 +02:00