Commit Graph

299 Commits

Author SHA1 Message Date
Maximilian Grundke
d2a089d057 Add structured errors to schema 2017-07-03 10:09:48 +02:00
Maximilian Grundke
30375a4909 Make comments available to RFC 2017-06-09 14:39:33 +02:00
Niklas Kiefer
5949d1208e Merge branch 'master' into client-routesv2 2017-04-25 13:50:08 +02:00
rteusner
e15c3d433f Merge pull request #117 from openHPI/ImproveUserfeedback
added user feedback page after submission of scores
2017-04-18 17:05:40 +02:00
Ralf Teusner
d053850572 fixed response in order to redirect correctly on ajax requests. Fixed policy 2017-04-18 16:51:02 +02:00
Thomas Hille
b9fb743cf8 fix NaN exception if user attend spielweise 2017-04-12 13:24:56 +02:00
Thomas Hille
8ca944558c improved texts of feedback, added ok button 2017-04-12 10:13:23 +02:00
rteusner
73a7d9ef4d Merge pull request #110 from ThommyH/reduceInterventionAmount
do not show interventions on solved exercises, reduce to 2 interventions per day
2017-04-03 18:52:51 +02:00
Thomas Hille
5a099a42b8 changed working time calculation to only consider submissions within 5 minutes instead of 30 2017-04-03 18:09:30 +02:00
Ralf Teusner
8197d40c6c fixed copy and paste error... 2017-04-03 17:20:50 +02:00
Thomas Hille
392dd77b4a do not show interventions on solved exercises
do not show more than 2 interventions per day
2017-04-03 17:17:34 +02:00
Ralf Teusner
ce2823e871 restrict name to be set to lis_person_name_full (should be display name) or to lis_person_name_given (should be first name).
don't use xikolo api any longer for consumer openHPI, use the values in CodeOcean.
2017-04-03 15:26:02 +02:00
Ralf Teusner
778ee7c374 correct the fallback 2017-04-03 15:16:41 +02:00
Ralf Teusner
dc702f3d6e fix 2017-04-03 14:28:57 +02:00
Ralf Teusner
156d921145 removed the possibility that the name of external users might be in the displayname alltogether 2017-04-03 13:22:12 +02:00
Ralf Teusner
75481d902b added a nil check for consumer. 2017-04-03 13:13:58 +02:00
Ralf Teusner
59bbb3edeb set the default to_s of user to displayname 2017-04-03 11:45:39 +02:00
Thomas Hille
20c8a95a87 quickfix 2017-03-30 16:56:55 +02:00
Thomas Hille
ad29551bb4 added code to test bonus exercise with different descriptions. 2017-03-30 16:54:22 +02:00
Thomas Hille
d4a9df709a quickfixed not working Exercise.accumulated_working_time_for_only(user) 2017-03-30 15:02:44 +02:00
rteusner
15c0020f8c Merge pull request #102 from ThommyH/ignoreDummyExerciseForRecommendation
ignore dummy exercise in recommendation
2017-03-28 13:53:25 +02:00
rteusner
80f8bddab1 Merge pull request #103 from ThommyH/fixWorkingTimeCalculation
Fix working time calculation
2017-03-28 13:53:03 +02:00
Thomas Hille
c8609ffa81 improved quantile calculation by using only times until user has reached max points 2017-03-28 12:29:36 +02:00
Thomas Hille
b9e93a5b21 fixed accumulated_working_time_for_only in exercise 2017-03-28 12:13:47 +02:00
Thomas Hille
e1f1134992 ignore dummy exercise in recommendation 2017-03-28 11:51:51 +02:00
Thomas Hille
d6a25b8496 do now assign dummy exercise to random group 2017-03-27 18:52:44 +02:00
Thomas Hille
ef5ebc3b69 splitted user in groups for assigning bonus exercises 2017-03-24 12:14:53 +01:00
Thomas Hille
26e93c4b23 changed puts methods in proxy_exercise.rb to Rails.logger.debug. also changed Rails.logger.info to Rails.logger.debug 2017-03-21 11:25:11 +01:00
Thomas Hille
4f5c936dd6 changed formulas for demising return 2017-03-21 10:31:45 +01:00
Thomas Hille
325c44c1fb added finishing return value in proxy exercise 2017-03-21 10:31:33 +01:00
Thomas Hille
530916d3ef added time of user to reach max score in exercise 2017-03-21 10:31:33 +01:00
Thomas Hille
7ef318713b added reason vor proxy exercise 2017-03-21 10:31:33 +01:00
Thomas Hille
695b8946f6 added search intervention. search opens new tab with search in the java course (at least in chrome)
send only 3 interventions per exercise at maximum
2017-03-21 10:31:33 +01:00
Thomas Hille
bfc96328c4 added interventions back to code. added post method to be able to save interventions 2017-03-21 10:31:33 +01:00
Thomas Hille
3d7f5bdf1a added intervention controller and stuff 2017-03-21 10:31:32 +01:00
Thomas Hille
b41a858762 changed way working times are returned. builtin protection if exercise is new 2017-03-21 10:31:32 +01:00
Thomas Hille
1f141f440a added fallback to recommendation if something went completely wrong 2017-03-21 10:31:32 +01:00
Thomas Hille
355e8af14b privatized methods in proxy_exercise 2017-03-21 10:31:32 +01:00
Thomas Hille
66a2d8c992 minor change 2017-03-21 10:31:32 +01:00
Thomas Hille
1eea3fab4c lots of renaming to _ names instead of camelCase 2017-03-21 10:31:32 +01:00
Thomas Hille
f63b9eeb3c added that users would only get exercises recommended which are max 1 level more difficult 2017-03-21 10:31:32 +01:00
Thomas Hille
1d75af51d2 quick fix 2017-03-21 10:31:32 +01:00
Thomas Hille
5bbc124097 improvement debug output 2017-03-21 10:31:32 +01:00
Thomas Hille
01470bff97 fixed problem with wrong worktime calculations 2017-03-21 10:31:32 +01:00
Thomas Hille
fe8b04fcfc more debugging infos 2017-03-21 10:31:32 +01:00
Thomas Hille
4796dd5c9d find solved exercises of users now by fetching submissions with cause assess or submit 2017-03-21 10:31:32 +01:00
Thomas Hille
0f67297e2c recommendation also now returns easiest exercise as recommendation if no tag matched could be found
findMatchingExercises only searched for assessed submissions to get processed exercises, fixed this to look at all submissions
2017-03-21 10:31:32 +01:00
Thomas Hille
9bef1d8bb2 recommendation also with lots of debugging messages looks promising 2017-03-21 10:31:32 +01:00
Thomas Hille
04c54549c5 zwischenstand 2017-03-21 10:31:32 +01:00
Thomas Hille
16a3bad453 renaming method 2017-03-21 10:31:32 +01:00