htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,756 Commits 2 Branches 0 Tags
fc1b5bfa6bad34a849c5497f034d45b18a61a2f0
Commit Graph

5756 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastian Serth
b2f409fe63 Bundle update 2023-09-25 17:31:31 +02:00
kiragrammel
b9ac2e7fdf Adapt text for forced pair programming exercise 2023-09-25 17:29:40 +02:00
Sebastian Serth
26ea69eba8 Require pair programming for a given set of exercises 2023-09-25 17:29:40 +02:00
dependabot[bot]
934bb001bc Bump rubocop-rspec from 2.24.0 to 2.24.1 
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.24.0 to 2.24.1.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.24.0...v2.24.1)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-25 03:24:04 +00:00
Sebastian Serth
077af74671 Connection::Buffer: Restore buffering for lines ending with CR 
With the turtle graphics, some very long lines might be returned by Poseidon just after the CR (\r). In this case, our new normalization will fix the mistake, but the next message received (just a LF `\n`) will be forwarded to the clients unchanged. This is not desired, so that we filter this case separately.
 2023-09-24 16:29:08 +02:00
Sebastian Serth
4690dbee32 PyLint: Fix recognition of new lines 
Since we prevent \r\r\n line breaks in the buffer (and rather return \r\n), we can also change the recognition of line breaks for the ASSERTION_ERROR_REGEXP.
 2023-09-24 15:46:57 +02:00
Sebastian Serth
ef63ebfecf JUnit 4: Fix broken arrayEquals comparison 
This test still checked for a \r\n, which is why we modified the RegEx. Further, during testing of this change, I noticed that the line number 50 was outdated and only valid for JUnit 4.11. Since we updated to 4.13 recently, we need to find another mechanism to check for the correct line.
 2023-09-24 15:43:58 +02:00
Sebastian Serth
515a81537c Connection::Buffer: Prevent modification of line breaks in quotes 
After splitting the messages received into lines, we could still have a line break within quotes. Since we just want to modify terminating line breaks, we change the recognition accordingly.
 2023-09-24 15:42:26 +02:00
Sebastian Serth
64c1a1cb6f Connection::Buffer: Handle Python doc string correctly 
In Python, a so-called doc string consists of a string encoded in three quote (starting and ending with """ or '''). These strings were not yet recognized correctly, so that line breaks there would cause further trouble with recognizing individual lines (which is important for the linter translation).
 2023-09-24 15:38:58 +02:00
Sebastian Serth
968fd5b864 Connection::Buffer: Fix recognition of incoming CLRF line endings 
Previously, a message received with CRLF line endings was (incorrectly) converted to CRCRLF line endings (i.e., from \r\n to \r\r\n). Then, the splitting in individual lines could generate an "empty" line, just containing the newly-added CR line ending \r.
 2023-09-24 14:10:06 +02:00
Sebastian Serth
e5678483cc Prevent duplicated 'pp_work_alone' events. 
* Ensure only one `pp_work_alone` event is stored.
* Disable Turbolinks for Programming Groups Work Alone, so that the implement page is requested normally. Otherwise, Turbolinks would load the page first, just to notice that it needs to reload the page afterwards to include Highlight.js for the tips.
 2023-09-23 20:45:49 +02:00
Sebastian Serth
47dd4cf4f7 Further check for programming group and add custom logging 
Fixes CODEOCEAN-V2
 2023-09-22 16:54:54 +02:00
Sebastian Serth
40aa50f772 Fix Pair Programming status for automatically matched learners 2023-09-21 18:55:24 +02:00
Sebastian Serth
bd1090be31 Store whether learners were manually invited to a programming group 2023-09-21 18:55:24 +02:00
Sebastian Serth
dd78c18b87 Only identify users as working alone without an active programming group 2023-09-21 18:55:23 +02:00
Kira Grammel
9f837412c7 Add waiting room to create programming groups (#1919) 
Co-authored-by: Sebastian Serth <Sebastian.Serth@hpi.de>
 2023-09-21 15:07:10 +02:00
Sebastian Serth
1dfc306e76 Refactor passing of parameters for LaExerciseChannel 2023-09-21 11:56:35 +02:00
Sebastian Serth
8cfb9d22c1 Use Ruby interval for where query 2023-09-21 11:27:12 +02:00
Sebastian Serth
b77c98b03f Add missing has_many associations for Users 2023-09-21 11:27:12 +02:00
dependabot[bot]
c467cfb976 Bump puma from 6.3.1 to 6.4.0 
Bumps [puma](https://github.com/puma/puma) from 6.3.1 to 6.4.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v6.3.1...v6.4.0)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-21 09:59:13 +02:00
dependabot[bot]
657a2546ce Bump actions/checkout from 3 to 4 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-21 09:57:30 +02:00
Sebastian Serth
5d8091cf67 Add Dependabot for GitHub actions 2023-09-21 09:45:20 +02:00
dependabot[bot]
d03e0b7841 Bump sass from 1.67.0 to 1.68.0 
Bumps [sass](https://github.com/sass/dart-sass) from 1.67.0 to 1.68.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.67.0...1.68.0)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-21 09:41:34 +02:00
Sebastian Serth
3bf4cb8d7b Bundle update 2023-09-20 23:58:58 +02:00
Sebastian Serth
06cde49901 Keep var for global ProgrammingGroups object 
Otherwise, Turbolinks might cause some nasty redefinition errors.

Fixes CODEOCEAN-FRONTEND-3W
Fixes CODEOCEAN-FRONTEND-3X
 2023-09-20 23:56:13 +02:00
Sebastian Serth
69cc0f3c25 Retry storing LTI data on invalid record 
We might receive a `RecordInvalid` error, if one part (such as the external user) is already assigned (not unique). Hence, we just retry.

Fixes CODEOCEAN-TZ
 2023-09-20 23:53:35 +02:00
Sebastian Serth
bd97c18a6c Add Sentry context for ActionCable 2023-09-20 23:45:12 +02:00
Sebastian Serth
8d04eacd35 Check for active programming group and session ID before unsubscribing 
Fixes CODEOCEAN-VJ
 2023-09-20 23:45:12 +02:00
Sebastian Serth
1bd0cd9a56 Require programming group for streaming the editor 
Potentially fixes CODEOCEAN-V2
 2023-09-20 23:31:54 +02:00
Sebastian Serth
f49d1c6a7b Catch EOFError when sending LTI scores 
Fixes CODEOCEAN-VN
Fixes CODEOCEAN-VP
 2023-09-20 23:19:48 +02:00
Sebastian Serth
03637b3185 Buffer: Buffer messages with incomplete quotes 
If a non-JSON message received contains quotes and is cut off weirdly, the following message might "quote" the line breaks. Then, we have an issue and cause \r\n\n for the further processing within the CodeOcean backend.
 2023-09-20 22:35:26 +02:00
Sebastian Serth
b5cb5c16dd Buffer: Split only complete lines ending with \r\n 
This change is required for Turtle output generated by the Python environment. Otherwise, drawing some images could add empty new lines (in the browser), since the original JSON message got split between the ending \r\n characters.
 2023-09-20 22:33:59 +02:00
Sebastian Serth
1bba4a006a Sentry: Check for span description before applying gsub! 2023-09-20 15:32:17 +02:00
Sebastian Serth
dca32c76e1 Bundle update 2023-09-20 12:04:52 +02:00
dependabot[bot]
c7999d4616 Bump bootswatch from 5.3.1 to 5.3.2 
Bumps [bootswatch](https://github.com/thomaspark/bootswatch) from 5.3.1 to 5.3.2.
- [Commits](https://github.com/thomaspark/bootswatch/commits)

---
updated-dependencies:
- dependency-name: bootswatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-20 03:43:48 +00:00
Sebastian Serth
04fccc7c31 Bundle update 2023-09-20 00:35:50 +02:00
Sebastian Serth
6d107ba2f4 Fix Linter translation with multi-line expression 
Fixes CODEOCEAN-V1
 2023-09-20 00:35:50 +02:00
Sebastian Serth
937a0d7d4d Disallow learners from clicking any button while redirecting after submit 
Fixes CODEOCEAN-FRONTEND-3M
 2023-09-20 00:35:18 +02:00
Sebastian Serth
9a6d590a80 Fix missing Sentry settings for JS initializer 
Fixes CODEOCEAN-FRONTEND-2W
 2023-09-20 00:35:18 +02:00
Sebastian Serth
6f3b72d207 Fix missing Sentry span for WebSocket close 
Fixes CODEOCEAN-FRONTEND-3C
 2023-09-20 00:35:18 +02:00
Sebastian Serth
2200fa427e Gracely handle missing editor_for_file 
Fixes CODEOCEAN-FRONTEND-3H
 2023-09-20 00:35:18 +02:00
Sebastian Serth
d01a3b7bac Fix incorrect translation for "Check invitation" explanation 
Amends 8a5dc7ab
 2023-09-20 00:35:17 +02:00
kiragrammel
d224a099e0 Return if editor is not defined 
Fixes CODEOCEAN-FRONTEND-3A
 2023-09-19 22:32:14 +02:00
kiragrammel
51fc44c2da Allow empty lines for current_content event 
Fixes CODEOCEAN-VR
 2023-09-19 22:32:14 +02:00
Kira Grammel
8a5dc7abc0 Forward person when a programming group is created with them 
Further, we remove the "check invitation" button and extract some methods to our new ProgrammingGroups object in JavaScript.

Co-authored-by: Sebastian Serth <Sebastian.Serth@hpi.de>
 2023-09-19 20:14:33 +00:00
Sebastian Serth
9848c900c3 Fix incorrect label and form association. 
This change is required for a better accessibility compatibility.
 2023-09-19 15:43:02 +02:00
Sebastian Serth
652f3fefcb Transform data privacy link from locales to view 
Amends #1899
 2023-09-19 15:38:25 +02:00
Sebastian Serth
1fcc81d852 Update JSONSchemer to newest version 
The issues with the unrecognized type have been resolved, allowing us to upgrade again.
 2023-09-19 12:52:53 +02:00
Maximilian Paß
72009667a6 Fix Poseidon JSON schema 
that included a wrong usage of the `required` attribute.

See #1914 and openHPI/poseidon#456.
 2023-09-19 12:52:53 +02:00
Sebastian Serth
f150c793d5 Add regression spec for message validation 2023-09-19 12:52:53 +02:00