htwkmooc/poseidon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flaky test TestDestroysRunnerAfterTimeoutAndSignal.

Browse Source
This commit is contained in:
Maximilian Paß
2023-10-30 15:44:41 +01:00
committed by Sebastian Serth
parent d0dd5c08cb
commit 160a097d07
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/runner/nomad_runner_test.go
View File

@ -263,7 +263,9 @@ func (s *ExecuteInteractivelyTestSuite) TestDestroysRunnerAfterTimeoutAndSignal(
defaultExecutionID, bytes.NewBuffer(make([]byte, 1)), nil, nil, context.Background()) defaultExecutionID, bytes.NewBuffer(make([]byte, 1)), nil, nil, context.Background())
s.Require().NoError(err) s.Require().NoError(err)
<-time.After(executionTimeoutGracePeriod + time.Duration(timeLimit)*time.Second + tests.ShortTimeout) <-time.After(executionTimeoutGracePeriod + time.Duration(timeLimit)*time.Second)
// Even if we expect the timeout to be exceeded now, Poseidon sometimes take a couple of hundred ms longer.
<-time.After(2 * tests.ShortTimeout)
s.manager.AssertNotCalled(s.T(), "Return", s.runner) s.manager.AssertNotCalled(s.T(), "Return", s.runner)
s.apiMock.AssertCalled(s.T(), "DeleteJob", s.runner.ID()) s.apiMock.AssertCalled(s.T(), "DeleteJob", s.runner.ID())
s.True(runnerDestroyed) s.True(runnerDestroyed)