Implement review comments

This commit is contained in:
Maximilian Paß
2022-02-22 16:47:13 +01:00
parent df68461264
commit 2cf890ab91
15 changed files with 109 additions and 110 deletions

View File

@ -45,7 +45,7 @@ func TestAWSRunnerManager_Claim(t *testing.T) {
assert.NotNil(t, r)
})
t.Run("forwards request for non AWS environments", func(t *testing.T) {
t.Run("forwards request for non-AWS environments", func(t *testing.T) {
nextHandler := &ManagerMock{}
nextHandler.On("Claim", mock.AnythingOfType("dto.EnvironmentID"), mock.AnythingOfType("int")).
Return(nil, nil)
@ -74,7 +74,7 @@ func TestAWSRunnerManager_Return(t *testing.T) {
assert.NotContains(t, m.usedRunners.List(), r)
})
t.Run("calls nextHandler for non AWS runner", func(t *testing.T) {
t.Run("calls nextHandler for non-AWS runner", func(t *testing.T) {
nextHandler := &ManagerMock{}
nextHandler.On("Return", mock.AnythingOfType("*runner.NomadJob")).Return(nil)
m.SetNextHandler(nextHandler)