Implement review comments

2022-02-22 16:47:13 +01:00
parent df68461264
commit 2cf890ab91
15 changed files with 109 additions and 110 deletions
--- a/internal/runner/nomad_runner.go
+++ b/internal/runner/nomad_runner.go
@ -46,6 +46,8 @@ type NomadJob struct {
 }

 // NewNomadJob creates a new NomadJob with the provided id.
+// The InactivityTimer is used actively. It executes onDestroy when it has expired.
+// The InactivityTimer is persisted in Nomad by the runner manager's Claim Function.
 func NewNomadJob(id string, portMappings []nomadApi.PortMapping,
 	apiClient nomad.ExecutorAPI, onDestroy DestroyRunnerHandler,
 ) *NomadJob {