Fix early write

Because some clients fail receiving a response before the body is sent entirely. See https://github.com/openHPI/poseidon/issues/54
This commit is contained in:
Maximilian Paß
2021-12-16 16:00:08 +01:00
parent f3929cbf50
commit 2f5b30702a
2 changed files with 25 additions and 2 deletions

View File

@ -8,6 +8,7 @@ import (
"github.com/openHPI/poseidon/internal/config"
"github.com/openHPI/poseidon/internal/runner"
"github.com/openHPI/poseidon/pkg/dto"
"io"
"net/http"
"net/url"
)
@ -131,6 +132,12 @@ func (r *RunnerController) findRunnerMiddleware(next http.Handler) http.Handler
runnerID := mux.Vars(request)[RunnerIDKey]
targetRunner, err := r.manager.Get(runnerID)
if err != nil {
// We discard the request body because an early write causes errors for some clients.
// See https://github.com/openHPI/poseidon/issues/54
_, readErr := io.ReadAll(request.Body)
if readErr != nil {
log.WithError(readErr).Warn("Failed to discard the request body")
}
writeNotFound(writer, err)
return
}