Revert "Debug Health route latency."

This reverts commit 213628b958.
This commit is contained in:
Maximilian Paß
2024-01-26 22:34:07 +01:00
committed by Sebastian Serth
parent 213628b958
commit 317590d3ea

View File

@ -1,18 +1,13 @@
package api
import (
"context"
"errors"
"fmt"
"github.com/coreos/go-systemd/v22/daemon"
"github.com/openHPI/poseidon/internal/config"
"github.com/openHPI/poseidon/internal/environment"
"github.com/openHPI/poseidon/pkg/dto"
"net/http"
"os"
"runtime/pprof"
"strings"
"time"
)
var ErrorPrewarmingPoolDepleting = errors.New("the prewarming pool is depleting")
@ -22,10 +17,6 @@ var ErrorPrewarmingPoolDepleting = errors.New("the prewarming pool is depleting"
// If it is not, the response won't reach the client.
func Health(manager environment.Manager) http.HandlerFunc {
return func(writer http.ResponseWriter, request *http.Request) {
ctx, cancel := context.WithCancel(request.Context())
defer cancel()
go debugGoroutines(ctx)
if err := checkPrewarmingPool(manager); err != nil {
sendJSON(writer, &dto.InternalServerError{Message: err.Error(), ErrorCode: dto.PrewarmingPoolDepleting},
http.StatusServiceUnavailable, request.Context())
@ -49,24 +40,3 @@ func checkPrewarmingPool(manager environment.Manager) error {
}
return nil
}
// debugGoroutines temporarily debugs a behavior where we observe long latencies in the Health route.
func debugGoroutines(ctx context.Context) {
interval, err := daemon.SdWatchdogEnabled(false)
if err != nil || interval == 0 {
return
}
log.Trace("Starting timeout for debugging the Goroutines")
const notificationIntervalFactor = 3
select {
case <-ctx.Done():
return
case <-time.After(interval / notificationIntervalFactor):
log.Warn("Health route latency is too high")
err := pprof.Lookup("goroutine").WriteTo(os.Stderr, 1)
if err != nil {
log.WithError(err).Warn("Failed to log the goroutines")
}
}
}