From 3570f18202ef96de142dc8ae3f6df2895e85bbd6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maximilian=20Pa=C3=9F?= <22845248+mpass99@users.noreply.github.com> Date: Fri, 8 Apr 2022 16:19:49 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Sebastian Serth --- internal/environment/aws_environment.go | 3 ++- internal/runner/abstract_manager.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/environment/aws_environment.go b/internal/environment/aws_environment.go index 823d232..31415de 100644 --- a/internal/environment/aws_environment.go +++ b/internal/environment/aws_environment.go @@ -65,8 +65,9 @@ func (a *AWSEnvironment) IdleRunnerCount() int { } // PrewarmingPoolSize is neither supported nor required. It is handled transparently by AWS. +// For easy compatibility with CodeOcean, 1 is the static value. func (a *AWSEnvironment) PrewarmingPoolSize() uint { - return 0 + return 1 } // SetPrewarmingPoolSize is neither supported nor required. It is handled transparently by AWS. diff --git a/internal/runner/abstract_manager.go b/internal/runner/abstract_manager.go index 2411c00..6fa06fe 100644 --- a/internal/runner/abstract_manager.go +++ b/internal/runner/abstract_manager.go @@ -64,7 +64,7 @@ func (n *AbstractManager) EnvironmentStatistics() map[dto.EnvironmentID]*dto.Sta ID: int(e.ID()), PrewarmingPoolSize: e.PrewarmingPoolSize(), IdleRunners: uint(e.IdleRunnerCount()), - UsedRunners: 0, + UsedRunners: 0, // Adjusted later as the information is present in the specific runner manager. } }