Fix Goroutine Leak of Environment Get
that was caused by creating an intermediate environment `fetchedEnvironment` when fetching the environments but not removing it in case that we just copy its configuration to the existing environment.
This commit is contained in:
@@ -58,7 +58,7 @@ func (n *AbstractManager) Delete(id dto.EnvironmentID) (bool, error) {
|
||||
}
|
||||
|
||||
n.runnerManager.DeleteEnvironment(id)
|
||||
if err := e.Delete(); err != nil {
|
||||
if err := e.Delete(false); err != nil {
|
||||
return true, fmt.Errorf("could not delete environment: %w", err)
|
||||
}
|
||||
return true, nil
|
||||
|
Reference in New Issue
Block a user