From 5f35ba30a234f46cd765597f259bccb478fda8b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maximilian=20Pa=C3=9F?= <22845248+mpass99@users.noreply.github.com> Date: Thu, 3 Jun 2021 11:38:40 +0200 Subject: [PATCH] Remove data race in the runner length function --- Makefile | 2 +- runner/storage.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 434e523..aebe793 100644 --- a/Makefile +++ b/Makefile @@ -66,7 +66,7 @@ test: deps ## Run unit tests .PHONY: race race: deps ## Run data race detector - @go test -race -short $(UNIT_TESTS) + @go test -race -count=1 -short $(UNIT_TESTS) .PHONY: coverage coverage: deps ## Generate code coverage report diff --git a/runner/storage.go b/runner/storage.go index be0e86d..d4ef9e0 100644 --- a/runner/storage.go +++ b/runner/storage.go @@ -70,5 +70,7 @@ func (s *localRunnerStorage) Sample() (Runner, bool) { } func (s *localRunnerStorage) Length() int { + s.RLock() + defer s.RUnlock() return len(s.runners) }