Add tests for runners execute route
Co-authored-by: Tobias Kantusch <tobias.kantusch@student.hpi.uni-potsdam.de>
This commit is contained in:
150
api/runners_test.go
Normal file
150
api/runners_test.go
Normal file
@ -0,0 +1,150 @@
|
||||
package api
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"encoding/json"
|
||||
"github.com/gorilla/mux"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"gitlab.hpi.de/codeocean/codemoon/poseidon/api/dto"
|
||||
"gitlab.hpi.de/codeocean/codemoon/poseidon/environment/pool"
|
||||
"gitlab.hpi.de/codeocean/codemoon/poseidon/runner"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"net/url"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestFindRunnerMiddleware(t *testing.T) {
|
||||
runnerPool := pool.NewLocalRunnerPool()
|
||||
var capturedRunner runner.Runner
|
||||
|
||||
testRunner := runner.NewExerciseRunner("testRunner")
|
||||
runnerPool.AddRunner(testRunner)
|
||||
|
||||
testRunnerIdRoute := func(writer http.ResponseWriter, request *http.Request) {
|
||||
var ok bool
|
||||
capturedRunner, ok = runner.FromContext(request.Context())
|
||||
if ok {
|
||||
writer.WriteHeader(http.StatusOK)
|
||||
} else {
|
||||
writer.WriteHeader(http.StatusInternalServerError)
|
||||
}
|
||||
}
|
||||
|
||||
router := mux.NewRouter()
|
||||
router.Use(findRunnerMiddleware(runnerPool))
|
||||
router.HandleFunc("/test/{runnerId}", testRunnerIdRoute).Name("test-runner-id")
|
||||
|
||||
testRunnerRequest := func(t *testing.T, runnerId string) *http.Request {
|
||||
path, err := router.Get("test-runner-id").URL("runnerId", runnerId)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
request, err := http.NewRequest(
|
||||
http.MethodPost, path.String(), nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return request
|
||||
}
|
||||
|
||||
t.Run("sets runner in context if runner exists", func(t *testing.T) {
|
||||
capturedRunner = nil
|
||||
|
||||
recorder := httptest.NewRecorder()
|
||||
router.ServeHTTP(recorder, testRunnerRequest(t, testRunner.Id()))
|
||||
|
||||
assert.Equal(t, http.StatusOK, recorder.Code)
|
||||
assert.Equal(t, testRunner, capturedRunner)
|
||||
})
|
||||
|
||||
t.Run("returns 404 if runner does not exist", func(t *testing.T) {
|
||||
recorder := httptest.NewRecorder()
|
||||
router.ServeHTTP(recorder, testRunnerRequest(t, "some-invalid-runner-id"))
|
||||
|
||||
assert.Equal(t, http.StatusNotFound, recorder.Code)
|
||||
})
|
||||
}
|
||||
|
||||
func TestExecuteRoute(t *testing.T) {
|
||||
runnerPool := pool.NewLocalRunnerPool()
|
||||
|
||||
router := NewRouter(runnerPool)
|
||||
|
||||
testRunner := runner.NewExerciseRunner("testRunner")
|
||||
runnerPool.AddRunner(testRunner)
|
||||
allocateExecutionMap(testRunner)
|
||||
|
||||
path, err := router.Get("runner-execute").URL("runnerId", testRunner.Id())
|
||||
if err != nil {
|
||||
t.Fatal("Could not construct execute url")
|
||||
}
|
||||
|
||||
t.Run("valid request", func(t *testing.T) {
|
||||
recorder := httptest.NewRecorder()
|
||||
executionRequest := dto.ExecutionRequest{
|
||||
Command: "command",
|
||||
TimeLimit: 10,
|
||||
Environment: nil,
|
||||
}
|
||||
body, err := json.Marshal(executionRequest)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
request, err := http.NewRequest(http.MethodPost, path.String(), bytes.NewReader(body))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
router.ServeHTTP(recorder, request)
|
||||
|
||||
responseBody, err := io.ReadAll(recorder.Result().Body)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
var websocketResponse dto.WebsocketResponse
|
||||
err = json.Unmarshal(responseBody, &websocketResponse)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
t.Run("returns 200", func(t *testing.T) {
|
||||
assert.Equal(t, http.StatusOK, recorder.Code)
|
||||
})
|
||||
|
||||
t.Run("creates an execution request for the runner", func(t *testing.T) {
|
||||
url, err := url.Parse(websocketResponse.WebsocketUrl)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
executionId := url.Query().Get("executionId")
|
||||
|
||||
assert.Equal(t, executionRequest, executions[testRunner.Id()][executionId])
|
||||
})
|
||||
})
|
||||
|
||||
t.Run("invalid request", func(t *testing.T) {
|
||||
recorder := httptest.NewRecorder()
|
||||
|
||||
body := ""
|
||||
|
||||
request, err := http.NewRequest(http.MethodPost, path.String(), strings.NewReader(body))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
router.ServeHTTP(recorder, request)
|
||||
|
||||
_, err = io.ReadAll(recorder.Result().Body)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
t.Run("returns 400", func(t *testing.T) {
|
||||
assert.Equal(t, http.StatusBadRequest, recorder.Code)
|
||||
})
|
||||
|
||||
})
|
||||
}
|
Reference in New Issue
Block a user