From 67297ec5a27e90b48daa4d4e431088a5ec55dab5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maximilian=20Pa=C3=9F?= <22845248+mpass99@users.noreply.github.com> Date: Tue, 29 Aug 2023 23:05:15 +0200 Subject: [PATCH] Add regression test for rescheduled idle runner. --- internal/runner/nomad_manager_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/runner/nomad_manager_test.go b/internal/runner/nomad_manager_test.go index acb94ff..0e283ed 100644 --- a/internal/runner/nomad_manager_test.go +++ b/internal/runner/nomad_manager_test.go @@ -373,6 +373,15 @@ func (s *ManagerTestSuite) TestOnAllocationAdded() { } func (s *ManagerTestSuite) TestOnAllocationStopped() { + s.Run("returns false for idle runner", func() { + environment, ok := s.nomadRunnerManager.environments.Get(tests.DefaultEnvironmentIDAsString) + s.Require().True(ok) + mockIdleRunners(environment.(*ExecutionEnvironmentMock)) + + environment.AddRunner(NewNomadJob(tests.DefaultRunnerID, []nomadApi.PortMapping{}, s.apiMock, func(r Runner) error { return nil })) + alreadyRemoved := s.nomadRunnerManager.onAllocationStopped(tests.DefaultRunnerID, nil) + s.False(alreadyRemoved) + }) s.Run("stops inactivity timer", func() { testStoppedInactivityTimer(s, true) })