Cleanup code

This changes variable names that were abbreviations, uses more constants
from the net/http package and improves the json decoding / encoding.
This commit is contained in:
Felix Auringer
2021-04-27 08:47:11 +02:00
parent 78668ad430
commit 712d0e6420
4 changed files with 17 additions and 14 deletions

View File

@@ -9,15 +9,15 @@ import (
)
func TestHealthRoute(t *testing.T) {
req, err := http.NewRequest("GET", "/health", nil)
request, err := http.NewRequest(http.MethodGet, "/health", nil)
if err != nil {
t.Fatal(err)
}
rec := httptest.NewRecorder()
http.HandlerFunc(Health).ServeHTTP(rec, req)
res := &Message{}
_ = json.NewDecoder(rec.Body).Decode(res)
recorder := httptest.NewRecorder()
http.HandlerFunc(Health).ServeHTTP(recorder, request)
result := Message{}
_ = json.Unmarshal(recorder.Body.Bytes(), &result)
assert.Equal(t, http.StatusOK, rec.Code)
assert.Equal(t, "I'm alive!", res.Msg)
assert.Equal(t, http.StatusOK, recorder.Code)
assert.Equal(t, "I'm alive!", result.Message)
}