Add initial structure of influxdb monitoring.

This commit is contained in:
Maximilian Paß
2022-04-09 17:51:34 +02:00
parent e4ebb5b384
commit 8feffdae3a
12 changed files with 225 additions and 20 deletions

View File

@ -2,6 +2,7 @@ package api
import (
"github.com/gorilla/mux"
influxdb2API "github.com/influxdata/influxdb-client-go/v2/api"
"github.com/openHPI/poseidon/internal/api/auth"
"github.com/openHPI/poseidon/internal/config"
"github.com/openHPI/poseidon/internal/environment"
@ -27,12 +28,14 @@ const (
// always returns a router for the newest version of our API. We
// use gorilla/mux because it is more convenient than net/http, e.g.
// when extracting path parameters.
func NewRouter(runnerManager runner.Manager, environmentManager environment.ManagerHandler) *mux.Router {
func NewRouter(runnerManager runner.Manager, environmentManager environment.ManagerHandler,
influxClient influxdb2API.WriteAPI) *mux.Router {
router := mux.NewRouter()
// this can later be restricted to a specific host with
// `router.Host(...)` and to HTTPS with `router.Schemes("https")`
configureV1Router(router, runnerManager, environmentManager)
router.Use(logging.HTTPLoggingMiddleware)
router.Use(logging.InfluxDB2Middleware(influxClient))
return router
}

View File

@ -31,7 +31,7 @@ func TestEnvironmentControllerTestSuite(t *testing.T) {
func (s *EnvironmentControllerTestSuite) SetupTest() {
s.manager = &environment.ManagerHandlerMock{}
s.router = NewRouter(nil, s.manager)
s.router = NewRouter(nil, s.manager, nil)
}
func (s *EnvironmentControllerTestSuite) TestList() {

View File

@ -8,6 +8,7 @@ import (
"github.com/openHPI/poseidon/internal/config"
"github.com/openHPI/poseidon/internal/runner"
"github.com/openHPI/poseidon/pkg/dto"
"github.com/openHPI/poseidon/pkg/logging"
"io"
"net/http"
"net/url"
@ -50,6 +51,8 @@ func (r *RunnerController) provide(writer http.ResponseWriter, request *http.Req
return
}
environmentID := dto.EnvironmentID(runnerRequest.ExecutionEnvironmentID)
logging.AddEnvironmentID(request, environmentID)
nextRunner, err := r.manager.Claim(environmentID, runnerRequest.InactivityTimeout)
if err != nil {
switch {
@ -63,18 +66,21 @@ func (r *RunnerController) provide(writer http.ResponseWriter, request *http.Req
}
return
}
logging.AddRunnerID(request, nextRunner.ID())
sendJSON(writer, &dto.RunnerResponse{ID: nextRunner.ID(), MappedPorts: nextRunner.MappedPorts()}, http.StatusOK)
}
// updateFileSystem handles the files API route.
// It takes an dto.UpdateFileSystemRequest and sends it to the runner for processing.
func (r *RunnerController) updateFileSystem(writer http.ResponseWriter, request *http.Request) {
logging.AddRequestSize(request)
fileCopyRequest := new(dto.UpdateFileSystemRequest)
if err := parseJSONRequestBody(writer, request, fileCopyRequest); err != nil {
return
}
targetRunner, _ := runner.FromContext(request.Context())
logging.AddRunnerID(request, targetRunner.ID())
if err := targetRunner.UpdateFileSystem(fileCopyRequest); err != nil {
log.WithError(err).Error("Could not perform the requested updateFileSystem.")
writeInternalServerError(writer, err, dto.ErrorUnknown)
@ -100,6 +106,7 @@ func (r *RunnerController) execute(writer http.ResponseWriter, request *http.Req
scheme = "ws"
}
targetRunner, _ := runner.FromContext(request.Context())
logging.AddRunnerID(request, targetRunner.ID())
path, err := r.runnerRouter.Get(WebsocketPath).URL(RunnerIDKey, targetRunner.ID())
if err != nil {
@ -151,6 +158,7 @@ func (r *RunnerController) findRunnerMiddleware(next http.Handler) http.Handler
// It destroys the given runner on the executor and removes it from the used runners list.
func (r *RunnerController) delete(writer http.ResponseWriter, request *http.Request) {
targetRunner, _ := runner.FromContext(request.Context())
logging.AddRunnerID(request, targetRunner.ID())
err := r.manager.Return(targetRunner)
if err != nil {

View File

@ -107,7 +107,7 @@ type RunnerRouteTestSuite struct {
func (s *RunnerRouteTestSuite) SetupTest() {
s.runnerManager = &runner.ManagerMock{}
s.router = NewRouter(s.runnerManager, nil)
s.router = NewRouter(s.runnerManager, nil, nil)
s.runner = runner.NewNomadJob("some-id", nil, nil, nil)
s.executionID = "execution"
s.runner.StoreExecution(s.executionID, &dto.ExecutionRequest{})
@ -253,6 +253,7 @@ func (s *UpdateFileSystemRouteTestSuite) SetupTest() {
s.Require().NoError(err)
s.path = routeURL.String()
s.runnerMock = &runner.RunnerMock{}
s.runnerMock.On("ID").Return(tests.DefaultMockID)
s.runnerManager.On("Get", tests.DefaultMockID).Return(s.runnerMock, nil)
s.recorder = httptest.NewRecorder()
}

View File

@ -8,6 +8,7 @@ import (
"github.com/gorilla/websocket"
"github.com/openHPI/poseidon/internal/runner"
"github.com/openHPI/poseidon/pkg/dto"
"github.com/openHPI/poseidon/pkg/logging"
"io"
"net/http"
"sync"
@ -336,6 +337,7 @@ func (wp *webSocketProxy) writeMessage(messageType int, data []byte) error {
// connectToRunner is the endpoint for websocket connections.
func (r *RunnerController) connectToRunner(writer http.ResponseWriter, request *http.Request) {
targetRunner, _ := runner.FromContext(request.Context())
logging.AddRunnerID(request, targetRunner.ID())
executionID := request.URL.Query().Get(ExecutionIDKey)
if !targetRunner.ExecutionExists(executionID) {
writeNotFound(writer, ErrUnknownExecutionID)

View File

@ -53,7 +53,7 @@ func (s *WebSocketTestSuite) SetupTest() {
runnerManager := &runner.ManagerMock{}
runnerManager.On("Get", s.runner.ID()).Return(s.runner, nil)
s.router = NewRouter(runnerManager, nil)
s.router = NewRouter(runnerManager, nil, nil)
s.server = httptest.NewServer(s.router)
}
@ -259,7 +259,7 @@ func TestWebsocketTLS(t *testing.T) {
runnerManager := &runner.ManagerMock{}
runnerManager.On("Get", r.ID()).Return(r, nil)
router := NewRouter(runnerManager, nil)
router := NewRouter(runnerManager, nil, nil)
server, err := helpers.StartTLSServer(t, router)
require.NoError(t, err)
@ -426,7 +426,7 @@ func newRunnerWithNotMockedRunnerManager(t *testing.T, apiMock *nomad.ExecutorAP
call.ReturnArguments = mock.Arguments{nil}
})
runnerManager := runner.NewNomadRunnerManager(apiMock, context.Background())
router := NewRouter(runnerManager, nil)
router := NewRouter(runnerManager, nil, nil)
server := httptest.NewServer(router)
runnerID := tests.DefaultRunnerID