From 909f347d2f2e8b990c219a45dc5049a2c7d267f0 Mon Sep 17 00:00:00 2001
From: sirkrypt0 <22522058+sirkrypt0@users.noreply.github.com>
Date: Tue, 20 Jul 2021 22:43:31 +0200
Subject: [PATCH] Remove tests dependency from nullreader test

Previously we had a dependency to the tests package. As the
nullreader package is in the pkg directory it should be publicly
available. However, having the tests dependency could lead to a
transitive dependency to an internal package, if the tests package
would import one. Thus, we removed it.
---
 pkg/nullreader/nullreader_test.go | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/pkg/nullreader/nullreader_test.go b/pkg/nullreader/nullreader_test.go
index a21b048..e606555 100644
--- a/pkg/nullreader/nullreader_test.go
+++ b/pkg/nullreader/nullreader_test.go
@@ -3,10 +3,12 @@ package nullreader
 import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"gitlab.hpi.de/codeocean/codemoon/poseidon/tests"
 	"testing"
+	"time"
 )
 
+const shortTimeout = 100 * time.Millisecond
+
 func TestNullReaderDoesNotReturnImmediately(t *testing.T) {
 	reader := &NullReader{}
 	readerReturned := make(chan bool)
@@ -16,5 +18,14 @@ func TestNullReaderDoesNotReturnImmediately(t *testing.T) {
 		require.NoError(t, err)
 		close(readerReturned)
 	}()
-	assert.False(t, tests.ChannelReceivesSomething(readerReturned, tests.ShortTimeout))
+
+	var received bool
+	select {
+	case <-readerReturned:
+		received = true
+	case <-time.After(shortTimeout):
+		received = false
+	}
+
+	assert.False(t, received)
 }