htwkmooc/poseidon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix linter emptyStringTest rule

Browse Source 
by replacing the length check with a string comparison.
This rule got introduced with the new GolangCI lint version.
This commit is contained in:
Maximilian Paß
2024-02-27 15:42:18 +01:00
parent 895dd8879f
commit 939904d406
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/api/api.go
View File

@ -77,7 +77,7 @@ func configureV1Router(router *mux.Router,
// It responds the release information stored in the configuration. // It responds the release information stored in the configuration.
func Version(writer http.ResponseWriter, request *http.Request) { func Version(writer http.ResponseWriter, request *http.Request) {
release := config.Config.Sentry.Release release := config.Config.Sentry.Release
if len(release) > 0 { if release != "" {
sendJSON(writer, release, http.StatusOK, request.Context()) sendJSON(writer, release, http.StatusOK, request.Context())
} else { } else {
writer.WriteHeader(http.StatusNotFound) writer.WriteHeader(http.StatusNotFound)

2
internal/api/environments.go
View File

@ -149,7 +149,7 @@ func parseEnvironmentID(request *http.Request) (dto.EnvironmentID, error) {
func parseFetchParameter(request *http.Request) (fetch bool, err error) { func parseFetchParameter(request *http.Request) (fetch bool, err error) {
fetchString := request.FormValue(fetchEnvironmentKey) fetchString := request.FormValue(fetchEnvironmentKey)
if len(fetchString) > 0 { if fetchString != "" {
fetch, err = strconv.ParseBool(fetchString) fetch, err = strconv.ParseBool(fetchString)
if err != nil { if err != nil {
return false, fmt.Errorf("could not parse fetch parameter: %w", err) return false, fmt.Errorf("could not parse fetch parameter: %w", err)

2
internal/config/config.go
View File

@ -273,7 +273,7 @@ func loadValue(prefix string, value reflect.Value, logEntry *logrus.Entry) {
} }
value.SetBool(boolean) value.SetBool(boolean)
case reflect.Slice: case reflect.Slice:
if len(content) > 0 && content[0] == '"' && content[len(content)-1] == '"' { if content != "" && content[0] == '"' && content[len(content)-1] == '"' {
content = content[1 : len(content)-1] // remove wrapping quotes content = content[1 : len(content)-1] // remove wrapping quotes
} }
parts := strings.Fields(content) parts := strings.Fields(content)