Fix CodeClimate duplication smells
by extracting one http helper method and increasing the threshold for duplication issues.
This commit is contained in:

committed by
Sebastian Serth

parent
7ac08b83d0
commit
97a2311a74
@ -1,5 +1,13 @@
|
||||
version: "2"
|
||||
|
||||
checks:
|
||||
similar-code:
|
||||
config:
|
||||
threshold: 110 # Golang default: 100
|
||||
identical-code:
|
||||
config:
|
||||
threshold: 110 # Golang default: 100
|
||||
|
||||
plugins:
|
||||
golint:
|
||||
enabled: false
|
||||
|
@ -117,13 +117,22 @@ func StartTLSServer(t *testing.T, router *mux.Router) (*httptest.Server, error)
|
||||
return server, nil
|
||||
}
|
||||
|
||||
// HTTPDelete sends a Delete Http Request with body to the passed url.
|
||||
func HTTPDelete(url string, body io.Reader) (response *http.Response, err error) {
|
||||
// httpRequest deduplicates the comment and error message wrapping the http.NewRequest call.
|
||||
func httpRequest(method, url string, body io.Reader) (*http.Request, error) {
|
||||
//nolint:noctx // we don't need a http.NewRequestWithContext in our tests
|
||||
req, err := http.NewRequest(http.MethodDelete, url, body)
|
||||
req, err := http.NewRequest(method, url, body)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("error creating request: %w", err)
|
||||
}
|
||||
return req, nil
|
||||
}
|
||||
|
||||
// HTTPDelete sends a "Delete" Http Request with body to the passed url.
|
||||
func HTTPDelete(url string, body io.Reader) (response *http.Response, err error) {
|
||||
req, err := httpRequest(http.MethodDelete, url, body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
client := &http.Client{}
|
||||
response, err = client.Do(req)
|
||||
if err != nil {
|
||||
@ -134,10 +143,9 @@ func HTTPDelete(url string, body io.Reader) (response *http.Response, err error)
|
||||
|
||||
// HTTPPatch sends a Patch Http Request with body to the passed url.
|
||||
func HTTPPatch(url, contentType string, body io.Reader) (response *http.Response, err error) {
|
||||
//nolint:noctx // we don't need a http.NewRequestWithContext in our tests
|
||||
req, err := http.NewRequest(http.MethodPatch, url, body)
|
||||
req, err := httpRequest(http.MethodPatch, url, body)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("error creating new request: %w", err)
|
||||
return nil, err
|
||||
}
|
||||
req.Header.Set("Content-Type", contentType)
|
||||
client := &http.Client{}
|
||||
@ -149,10 +157,9 @@ func HTTPPatch(url, contentType string, body io.Reader) (response *http.Response
|
||||
}
|
||||
|
||||
func HTTPPut(url string, body io.Reader) (response *http.Response, err error) {
|
||||
//nolint:noctx // we don't need a http.NewRequestWithContext in our tests
|
||||
req, err := http.NewRequest(http.MethodPut, url, body)
|
||||
req, err := httpRequest(http.MethodPut, url, body)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("error creating new request: %w", err)
|
||||
return nil, err
|
||||
}
|
||||
client := &http.Client{}
|
||||
resp, err := client.Do(req)
|
||||
|
Reference in New Issue
Block a user