htwkmooc/poseidon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Decrease Log severity

Browse Source 
of failing requests because it's likely that another error with more information has already been reported.
This commit is contained in:
Maximilian Paß
2023-11-29 13:28:51 +01:00
committed by Sebastian Serth
parent 6102759b7c
commit c9922e2539
2 changed files with 1 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/logging/logging.go
View File

@ -93,11 +93,7 @@ func HTTPLoggingMiddleware(next http.Handler) http.Handler {
"duration": latency,
"user_agent": RemoveNewlineSymbol(r.UserAgent()),
})
if lrw.StatusCode >= http.StatusInternalServerError {
logEntry.Error("Failing " + path)
} else {
logEntry.Debug()
}
logEntry.Debug()
})
}

16
pkg/logging/logging_test.go
View File

@ -25,22 +25,6 @@ func TestMainTestSuite(t *testing.T) {
suite.Run(t, new(MainTestSuite))
}
func (s *MainTestSuite) TestHTTPMiddlewareWarnsWhenInternalServerError() {
var hook *test.Hook
log, hook = test.NewNullLogger()
InitializeLogging(logrus.DebugLevel.String(), dto.FormatterText)
request, err := http.NewRequest(http.MethodGet, "/", http.NoBody)
if err != nil {
s.Fail(err.Error())
}
recorder := httptest.NewRecorder()
HTTPLoggingMiddleware(mockHTTPStatusHandler(500)).ServeHTTP(recorder, request)
s.Equal(1, len(hook.Entries))
s.Equal(logrus.ErrorLevel, hook.LastEntry().Level)
}
func (s *MainTestSuite) TestHTTPMiddlewareDebugsWhenStatusOK() {
var hook *test.Hook
log, hook = test.NewNullLogger()