Decrease Log severity

of failing requests because it's likely that another error with more information has already been reported.
This commit is contained in:
Maximilian Paß
2023-11-29 13:28:51 +01:00
committed by Sebastian Serth
parent 6102759b7c
commit c9922e2539
2 changed files with 1 additions and 21 deletions

View File

@ -93,11 +93,7 @@ func HTTPLoggingMiddleware(next http.Handler) http.Handler {
"duration": latency, "duration": latency,
"user_agent": RemoveNewlineSymbol(r.UserAgent()), "user_agent": RemoveNewlineSymbol(r.UserAgent()),
}) })
if lrw.StatusCode >= http.StatusInternalServerError { logEntry.Debug()
logEntry.Error("Failing " + path)
} else {
logEntry.Debug()
}
}) })
} }

View File

@ -25,22 +25,6 @@ func TestMainTestSuite(t *testing.T) {
suite.Run(t, new(MainTestSuite)) suite.Run(t, new(MainTestSuite))
} }
func (s *MainTestSuite) TestHTTPMiddlewareWarnsWhenInternalServerError() {
var hook *test.Hook
log, hook = test.NewNullLogger()
InitializeLogging(logrus.DebugLevel.String(), dto.FormatterText)
request, err := http.NewRequest(http.MethodGet, "/", http.NoBody)
if err != nil {
s.Fail(err.Error())
}
recorder := httptest.NewRecorder()
HTTPLoggingMiddleware(mockHTTPStatusHandler(500)).ServeHTTP(recorder, request)
s.Equal(1, len(hook.Entries))
s.Equal(logrus.ErrorLevel, hook.LastEntry().Level)
}
func (s *MainTestSuite) TestHTTPMiddlewareDebugsWhenStatusOK() { func (s *MainTestSuite) TestHTTPMiddlewareDebugsWhenStatusOK() {
var hook *test.Hook var hook *test.Hook
log, hook = test.NewNullLogger() log, hook = test.NewNullLogger()