htwkmooc/poseidon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix idle runner being memory leaked

Browse Source 
when its allocation is restarted by Nomad.

Fix logic created in 354c16cc.
This commit is contained in:
Maximilian Paß
2024-05-30 12:14:20 +02:00
parent 1ddccb308a
commit cbcd5f233e
7 changed files with 102 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/runner/nomad_manager.go
View File

@ -312,8 +312,8 @@ func (m *NomadRunnerManager) onAllocationStopped(runnerID string, reason error)
return false
}
r, stillActive := m.usedRunners.Get(runnerID)
if stillActive {
r, stillUsed := m.usedRunners.Get(runnerID)
if stillUsed {
m.usedRunners.Delete(runnerID)
if err := r.Destroy(reason); err != nil {
log.WithError(err).Warn("Runner of stopped allocation cannot be destroyed")
@ -321,12 +321,19 @@ func (m *NomadRunnerManager) onAllocationStopped(runnerID string, reason error)
}
environment, ok := m.GetEnvironment(environmentID)
if ok {
stillActive = stillActive || environment.DeleteRunner(runnerID)
go m.checkPrewarmingPoolAlert(environment, false)
if !ok {
return !stillUsed
}
return !stillActive
r, stillIdle := environment.DeleteRunner(runnerID)
if stillIdle {
if err := r.Destroy(reason); err != nil {
log.WithError(err).Warn("Runner of stopped allocation cannot be destroyed")
}
}
go m.checkPrewarmingPoolAlert(environment, false)
return !(stillUsed || stillIdle)
}
// onRunnerDestroyed is the callback when the runner destroys itself.