htwkmooc/poseidon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#42 Allow deletion of ./*

Browse Source
This commit is contained in:
Maximilian Paß
2022-06-09 22:33:34 +02:00
committed by Sebastian Serth
parent 59ca63268b
commit eecacc08bf
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/runner/nomad_runner.go
View File

@ -253,11 +253,15 @@ func fileDeletionCommand(pathsToDelete []dto.FilePath) string {
} }
command := "rm --recursive --force " command := "rm --recursive --force "
for _, filePath := range pathsToDelete { for _, filePath := range pathsToDelete {
// To avoid command injection, filenames need to be quoted. if filePath == "./*" {
// See https://unix.stackexchange.com/questions/347332/what-characters-need-to-be-escaped-in-files-without-quotes command += "./* "
// for details. } else {
singleQuoteEscapedFileName := strings.ReplaceAll(filePath.Cleaned(), "'", "'\\''") // To avoid command injection, filenames need to be quoted.
command += fmt.Sprintf("'%s' ", singleQuoteEscapedFileName) // See https://unix.stackexchange.com/questions/347332/what-characters-need-to-be-escaped-in-files-without-quotes
// for details.
singleQuoteEscapedFileName := strings.ReplaceAll(filePath.Cleaned(), "'", "'\\''")
command += fmt.Sprintf("'%s' ", singleQuoteEscapedFileName)
}
} }
command += ";" command += ";"
return command return command