htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Conccurrent::Future properly

Browse Source
This commit is contained in:
Sebastian Serth
2020-10-25 16:09:51 +01:00
parent 380b1a5ba1
commit 0988e41f6d
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/controllers/concerns/submission_scoring.rb
View File

@ -3,8 +3,8 @@ require 'concurrent/future'
module SubmissionScoring module SubmissionScoring
def collect_test_results(submission) def collect_test_results(submission)
# Mnemosyne.trace 'custom.codeocean.collect_test_results', meta: { submission: submission.id } do # Mnemosyne.trace 'custom.codeocean.collect_test_results', meta: { submission: submission.id } do
submission.collect_files.select(&:teacher_defined_assessment?).map do |file| futures = submission.collect_files.select(&:teacher_defined_assessment?).map do |file|
future = Concurrent::Future.execute do Concurrent::Future.execute do
# Mnemosyne.trace 'custom.codeocean.collect_test_results_block', meta: { file: file.id, submission: submission.id } do # Mnemosyne.trace 'custom.codeocean.collect_test_results_block', meta: { file: file.id, submission: submission.id } do
assessor = Assessor.new(execution_environment: submission.execution_environment) assessor = Assessor.new(execution_environment: submission.execution_environment)
output = execute_test_file(file, submission) output = execute_test_file(file, submission)
@ -32,9 +32,8 @@ module SubmissionScoring
output.merge!(filename: file.name_with_extension, message: feedback_message(file, output), weight: file.weight) output.merge!(filename: file.name_with_extension, message: feedback_message(file, output), weight: file.weight)
# end # end
end end
future.value
end end
# end futures.map(&:value)
end end
private :collect_test_results private :collect_test_results