htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix unnecessary testrun for each successful test / score action.

Browse Source 
This commit resolves a regression introduced by commit 9c3ec3c7.

We still might want to remove this false data from our database, which is still pending.
This commit is contained in:
Sebastian Serth
2023-07-15 18:58:52 +02:00
parent a630f70cea
commit 264927e3c4
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/submissions_controller.rb
View File

@ -263,7 +263,6 @@ class SubmissionsController < ApplicationController
kill_client_socket(client_socket) kill_client_socket(client_socket)
Rails.logger.debug { "Runner error while scoring submission #{@submission.id}: #{e.message}" } Rails.logger.debug { "Runner error while scoring submission #{@submission.id}: #{e.message}" }
@testrun[:passed] = false @testrun[:passed] = false
ensure
save_testrun_output 'assess' save_testrun_output 'assess'
end end
@ -297,7 +296,6 @@ class SubmissionsController < ApplicationController
kill_client_socket(client_socket) kill_client_socket(client_socket)
Rails.logger.debug { "Runner error while testing submission #{@submission.id}: #{e.message}" } Rails.logger.debug { "Runner error while testing submission #{@submission.id}: #{e.message}" }
@testrun[:passed] = false @testrun[:passed] = false
ensure
save_testrun_output 'assess' save_testrun_output 'assess'
end end