htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete UTF-16 characters completely in editor

Browse Source 
Previously, removing an UTF-16 character (such as emojis) required pressing the backspace twice. This was caused by ACE only handling single UTF-8 characters.

Fixes CODEOCEAN-GC
This commit is contained in:
Sebastian Serth
2023-02-28 16:27:47 +01:00
parent 252704b083
commit 2b11415dcd
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
app/assets/javascripts/editor/editor.js.erb
View File

@ -333,12 +333,38 @@ var CodeOceanEditor = {
editor.on("copy", this.handleCopyEvent.bind(element));
// listener for autosave
session.on("change", function (deltaObject) {
session.on("change", function (deltaObject, session) {
// TODO: This is a workaround for a bug in Ace. Remove when upgrading Ace.
this.handleUTF16Surrogates(deltaObject, session);
this.resetSaveTimer();
}.bind(this));
}.bind(this));
},
handleUTF16Surrogates: function (AceDeltaObject, AceSession) {
if (AceDeltaObject.data === undefined || AceDeltaObject.data.action !== "removeText") {
return;
}
const codePoint = AceDeltaObject.data.text.codePointAt(0);
if (0xDC00 <= codePoint && codePoint <= 0xDFFF) {
// The text contains a UTF-16 surrogate pair, and the only the lower part is removed.
// We need to remove the high surrogate pair as well.
const currentCharacter = AceDeltaObject.data.range
const previousCharacter = {
start: {
row: currentCharacter.start.row,
column: currentCharacter.start.column - 1
},
end: {
row: currentCharacter.start.row,
column: currentCharacter.start.column
}
}
AceSession.remove(previousCharacter);
}
},
initializeEventHandlers: function () {
$(document).on('click', '#results a', this.showOutput.bind(this));
$(document).on('keydown', this.handleKeyPress.bind(this));