htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reduced code complexity

Browse Source
This commit is contained in:
Hauke Klement
2015-02-12 15:10:53 +01:00
parent e8db4a4b10
commit 4fa4629e15
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/models/submission.rb
View File

@ -13,10 +13,15 @@ class Submission < ActiveRecord::Base
validates :cause, inclusion: {in: CAUSES} validates :cause, inclusion: {in: CAUSES}
validates :exercise_id, presence: true validates :exercise_id, presence: true
def build_files_hash(files, attribute)
files.map(&attribute.to_proc).zip(files).to_h
end
private :build_files_hash
def collect_files def collect_files
ancestors = exercise.files.map(&:id).zip(exercise.files) ancestors = build_files_hash(exercise.files, :id)
descendants = files.map(&:file_id).zip(files) descendants = build_files_hash(files, :file_id)
(ancestors + descendants).to_h.values ancestors.merge(descendants).values
end end
def execution_environment def execution_environment