htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make note "not graded" optional for linters

Browse Source
This commit is contained in:
Sebastian Serth
2020-11-09 21:19:24 +01:00
parent 69db6f98cf
commit 84c291626f
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/controllers/concerns/submission_scoring.rb
View File

@ -29,13 +29,18 @@ module SubmissionScoring
waiting_for_container_time: output[:waiting_for_container_time] waiting_for_container_time: output[:waiting_for_container_time]
) )
filename = file.name_with_extension
if file.teacher_defined_linter? if file.teacher_defined_linter?
LinterCheckRun.create_from(testrun, assessment) LinterCheckRun.create_from(testrun, assessment)
assessment = assessor.translate_linter(assessment) assessment = assessor.translate_linter(assessment)
# replace file name with hint if linter is not used for grading. Refactor!
filename = t('exercises.implement.not_graded') if file.weight.zero?
end end
output.merge!(assessment) output.merge!(assessment)
output.merge!(filename: file.name_with_extension, message: feedback_message(file, output), weight: file.weight) output.merge!(filename: filename, message: feedback_message(file, output), weight: file.weight)
# end # end
end end
end end

3
config/locales/de.yml
View File

@ -387,7 +387,8 @@ de:
messages: Meldungen messages: Meldungen
feedback: Feedback feedback: Feedback
test_file: 'Test-Datei <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)' test_file: 'Test-Datei <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)'
linter_file: 'Linter-Feedback (ohne Punkte)<span class="number d-none">%{number}</span><span class="filename d-none">%{filename}</span>' linter_file: 'Linter-Feedback <span class="number d-none">%{number}</span>(<span class="filename">%{filename}</span>)'
not_graded: ohne Punkte
hint: Hinweis hint: Hinweis
no_files: Die Aufgabe umfasst noch keine sichtbaren Dateien. no_files: Die Aufgabe umfasst noch keine sichtbaren Dateien.
no_output: Die letzte Code-Ausführung terminierte am %{timestamp} ohne Ausgabe. no_output: Die letzte Code-Ausführung terminierte am %{timestamp} ohne Ausgabe.

3
config/locales/en.yml
View File

@ -387,7 +387,8 @@ en:
messages: Messages messages: Messages
feedback: Feedback feedback: Feedback
test_file: 'Test File <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)' test_file: 'Test File <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)'
linter_file: 'Linter Feedback (not graded)<span class="number d-none">%{number}</span><span class="filename d-none">%{filename}</span>' linter_file: 'Linter Feedback <span class="number d-none">%{number}</span>(<span class="filename">%{filename}</span>)'
not_graded: not graded
hint: Hint hint: Hint
no_files: The exercise does not comprise visible files yet. no_files: The exercise does not comprise visible files yet.
no_output: The last code run finished on %{timestamp} without any output. no_output: The last code run finished on %{timestamp} without any output.