retrieve correct displaynames for users (from consumer if it is openHPI, otherwise use internal name)

app/models/external_user.rb

@@ -3,4 +3,13 @@ class ExternalUser < ActiveRecord::Base
 
   validates :consumer_id, presence: true
   validates :external_id, presence: true
+
+  def displayname
+    result = name
+    if(consumer.name == 'openHPI')
+      result = Xikolo::UserClient.get(external_id.to_s)[:display_name]
+    end
+    result
+  end
+
 end

app/models/internal_user.rb

@@ -21,4 +21,9 @@ class InternalUser < ActiveRecord::Base
   def teacher?
     role == 'teacher'
   end
+
+  def displayname
+    name
+  end
+
 end

app/views/request_for_comments/index.html.slim

@@ -13,7 +13,7 @@ h1 = RequestForComment.model_name.human(count: 2)
         tr data-id=request_for_comment.id
           td = link_to(request_for_comment.exercise.title, request_for_comment)
           td = request_for_comment.exercise.execution_environment
-          td = request_for_comment.user.name
+          td = request_for_comment.user.displayname
           td = request_for_comment.requested_at
 
 = render('shared/pagination', collection: @request_for_comments)