htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #234 from openHPI/fix_jquery

Browse Source 
Migrate jQuery function use for ajax in case of success or failure
This commit is contained in:
MrSerth
2018-11-26 12:35:19 +01:00
committed by GitHub
parent 0fbbe97ae4 16a5345a71
commit 94808cc9ef
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/editor/editor.js.erb
View File

@ -436,7 +436,7 @@ configureEditors: function () {
url: $('#editor').data('errors-url') url: $('#editor').data('errors-url')
}); });
jqxhr.always(this.hideSpinner); jqxhr.always(this.hideSpinner);
jqxhr.success(this.renderHint); jqxhr.done(this.renderHint);
}, },
toggleButtonStates: function () { toggleButtonStates: function () {

2
app/assets/javascripts/editor/participantsupport.js
View File

@ -83,7 +83,7 @@ CodeOceanEditorRequestForComments = {
$.flash.success({text: $('#askForCommentsButton').data('message-success')}); $.flash.success({text: $('#askForCommentsButton').data('message-success')});
// trigger a run // trigger a run
this.runSubmission.call(this, submission); this.runSubmission.call(this, submission);
}.bind(this)).error(this.ajaxError.bind(this)); }.bind(this)).fail(this.ajaxError.bind(this));
}; };
this.createSubmission($('#requestComments'), null, createRequestForComments.bind(this)); this.createSubmission($('#requestComments'), null, createRequestForComments.bind(this));

2
app/assets/javascripts/editor/submissions.js
View File

@ -106,7 +106,7 @@ CodeOceanEditorSubmissions = {
this.ajax({ this.ajax({
method: 'GET', method: 'GET',
url: $('#start-over').data('url') url: $('#start-over').data('url')
}).success(function(response) { }).done(function(response) {
this.hideSpinner(); this.hideSpinner();
_.each(this.editors, function(editor) { _.each(this.editors, function(editor) {
var file_id = $(editor.container).data('file-id'); var file_id = $(editor.container).data('file-id');

4
app/assets/javascripts/error_templates.js
View File

@ -8,9 +8,9 @@ $(document).on('turbolinks:load', function() {
dataType: 'json', dataType: 'json',
error_template_attribute_id: $('#add-attribute').find('select').val() error_template_attribute_id: $('#add-attribute').find('select').val()
} }
}).success(function () { }).done(function () {
location.reload(); location.reload();
}).error(function (error) { }).fail(function (error) {
$.flash.danger({text: error.statusText}); $.flash.danger({text: error.statusText});
}); });
}); });