htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused LTI params from session

Browse Source
This commit is contained in:
kiragrammel
2023-08-16 00:16:21 +02:00
committed by Sebastian Serth
parent 56b9bb2680
commit 97138288f4
4 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/application_controller.rb
View File

@ -67,7 +67,6 @@ class ApplicationController < ActionController::Base
# All external users are logged in "manually" # All external users are logged in "manually"
session[:external_user_id] = token.user.id session[:external_user_id] = token.user.id
session.delete(:lti_parameters_id)
token.user token.user
end end
end end

2
app/controllers/concerns/lti.rb
View File

@ -110,7 +110,6 @@ module Lti
else else
proxy_exercise.get_matching_exercise(current_user) proxy_exercise.get_matching_exercise(current_user)
end end
session[:lti_exercise_id] = @exercise.id if @exercise
refuse_lti_launch(message: t('sessions.oauth.invalid_exercise_token')) unless @exercise refuse_lti_launch(message: t('sessions.oauth.invalid_exercise_token')) unless @exercise
end end
@ -242,7 +241,6 @@ module Lti
@lti_parameters = lti_parameters @lti_parameters = lti_parameters
session[:external_user_id] = current_user.id session[:external_user_id] = current_user.id
session[:lti_parameters_id] = lti_parameters.id
end end
private :store_lti_session_data private :store_lti_session_data

4
app/controllers/concerns/redirect_behavior.rb
View File

@ -124,9 +124,7 @@ module RedirectBehavior
session: session.to_hash, session: session.to_hash,
submission: @submission.inspect, submission: @submission.inspect,
params: params.as_json, params: params.as_json,
current_user:, current_user:
lti_exercise_id: session[:lti_exercise_id],
lti_parameters_id: session[:lti_parameters_id]
) )
path = lti_return_path(submission_id: @submission.id) path = lti_return_path(submission_id: @submission.id)

3
spec/concerns/lti_spec.rb
View File

@ -22,8 +22,6 @@ describe Lti do
expect(controller.session).to receive(:delete).with(:external_user_id) expect(controller.session).to receive(:delete).with(:external_user_id)
expect(controller.session).to receive(:delete).with(:study_group_id) expect(controller.session).to receive(:delete).with(:study_group_id)
expect(controller.session).to receive(:delete).with(:embed_options) expect(controller.session).to receive(:delete).with(:embed_options)
expect(controller.session).to receive(:delete).with(:lti_exercise_id)
expect(controller.session).to receive(:delete).with(:lti_parameters_id)
controller.send(:clear_lti_session_data) controller.send(:clear_lti_session_data)
end end
end end
@ -174,7 +172,6 @@ describe Lti do
controller.instance_variable_set(:@current_user, create(:external_user)) controller.instance_variable_set(:@current_user, create(:external_user))
controller.instance_variable_set(:@exercise, create(:fibonacci)) controller.instance_variable_set(:@exercise, create(:fibonacci))
expect(controller.session).to receive(:[]=).with(:external_user_id, anything) expect(controller.session).to receive(:[]=).with(:external_user_id, anything)
expect(controller.session).to receive(:[]=).with(:lti_parameters_id, anything)
controller.send(:store_lti_session_data, consumer: build(:consumer), parameters:) controller.send(:store_lti_session_data, consumer: build(:consumer), parameters:)
end end